Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect asar integrity plist key #6507

Closed
indutny-signal opened this issue Dec 17, 2021 · 3 comments · Fixed by #6511
Closed

Incorrect asar integrity plist key #6507

indutny-signal opened this issue Dec 17, 2021 · 3 comments · Fixed by #6511

Comments

@indutny-signal
Copy link
Contributor

  • Electron-Builder Version: 22.14.5
  • Node Version: 16.9.1
  • Electron Version: 16.0.4
  • Electron Type (current, beta, nightly): current
  • Target: macOS

Electron uses different plist key (and format) for asar integrity:

<key>ElectronAsarIntegrity</key><dict><key>Resources/default_app.asar</key><dict><key>algorithm</key><string>SHA256</string><key>hash</key><string>857172e4d62de44b72638d5fa2f787dfd525c4bb666d729ed0e0c987af6b1f38</string></dict></dict>

compare to the one returned by electron-builder:

<key>AsarIntegrity</key><string>{&#34;checksums&#34;:{&#34;app.asar&#34;:&#34;bwX9ldnTOsgsdkaiaZqeLtNTkiMtfd9zFpvnOe113tCZWphBlQatLkRnqtFVQLSPVWoQ4wMFf218Iddg0EHFjQ==&#34;}}</string><
@indutny-signal
Copy link
Contributor Author

In addition to that the version of @electron/universal is fixed in app-builder-lib and so even that can't generate correct ElectronAsarIntegrity (even though @electron/universal would do it itself)

@indutny-signal
Copy link
Contributor Author

Also, electron supports only SHA256 integrity has while electron-builder provides SHA-512.

@indutny-signal indutny-signal mentioned this issue Dec 22, 2021
Closed
@indutny-signal
Copy link
Contributor Author

FWIW, I'm working on a PR for both #6506 and #6507

indutny-signal added a commit to indutny-signal/electron-builder that referenced this issue Dec 22, 2021
@indutny-signal
feat(mac): ElectronAsarIntegrity in electron@15
3f913df 
See: electron/electron#30667
Fix: electron-userland#6506
Fix: electron-userland#6507
@indutny-signal indutny-signal mentioned this issue Dec 22, 2021
Merged
indutny-signal added a commit to indutny-signal/electron-builder that referenced this issue Dec 22, 2021
@indutny-signal
feat(mac): ElectronAsarIntegrity in electron@15
7d7bedc 
See: electron/electron#30667
Fix: electron-userland#6506
Fix: electron-userland#6507
indutny-signal added a commit to indutny-signal/electron-builder that referenced this issue Dec 22, 2021
@indutny-signal
feat(mac): ElectronAsarIntegrity in electron@15
44bc253 
See: electron/electron#30667
Fix: electron-userland#6506
Fix: electron-userland#6507
indutny-signal added a commit to indutny-signal/electron-builder that referenced this issue Jan 5, 2022
@indutny-signal
feat(mac): ElectronAsarIntegrity in electron@15
ccc2e47 
See: electron/electron#30667
Fix: electron-userland#6506
Fix: electron-userland#6507
mmaietta pushed a commit that referenced this issue Jan 7, 2022
@indutny-signal
feat(mac): ElectronAsarIntegrity in electron@15 (#6511)
475f083 
* feat(mac): ElectronAsarIntegrity in electron@15
See: electron/electron#30667
Fix: #6506
Fix: #6507
@mmaietta mmaietta mentioned this issue Jan 16, 2022
Merged
mergify bot pushed a commit to enso-org/enso that referenced this issue Apr 21, 2022
@vitvakatu
Update electron-builder to v23.0.6 (#3410)
ea33387 
[ci no changelog needed]

[Task link](https://www.pivotaltracker.com/story/show/181944234).

It fixes the build issue on Mac OS 12.3.1 that is caused by removed `/usr/bin/python` executable.

Also applied `enso-formatter` to the sources.

# Important Notes
We're basically updating for one major `electron-builder` release - from `v22` to `v23`. I didn't spot anything in the changelog that could affect us. See features + breaking changes excerpt:

```
Features:

- feat(msi): add fileAssociation support for MSI target (electron-userland/electron-builder#6530)
- feat(mac): ElectronAsarIntegrity in electron@15 - See: electron/electron#30667 (electron-userland/electron-builder#6506 electron-userland/electron-builder#6507)
- feat(snap): add lzo to Snap compression options (also as new default) (electron-userland/electron-builder#6201) Upgraded app-builder-bin dependency required newer version of Go
- feat(msi): support assisted installer for MSI target (electron-userland/electron-builder#6550)

Breaking changes:

- Removing Bintray support since it was sunset. Ref: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
- Fail-fast for windows signature verification failures. Adding -LiteralPath to update file path to disregard injected wildcards
- Force strip path separators for backslashes on Windows during update process
- Authentication for local mac squirrel update server
- Disabled advertised shortcuts, since MSIs with advertised Start Menu shortcuts that have a
Shortcut Property fails to install when deployed machine-wide via GPO but works fine in all
other contexts. Admins using advertisement must apply an MST to re-enable it. See electron-userland/electron-builder#6508.
- Removing optional NSIS icon ID from config and generating it automatically to synchronize IDs with Advertised Shortcuts and future features
```
@dennismunene dennismunene mentioned this issue Jul 31, 2022
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mac): ElectronAsarIntegrity in electron@15 indutny-signal/electron-builder
1 participant
@indutny-signal