-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: buildkite release pipeline #509
base: main
Are you sure you want to change the base?
Conversation
run dry-run release TODO: define env variable with the TAG name
This reverts commit 3400b4c.
notify: | ||
- slack: "#observablt-bots" | ||
- slack: "#on-week-oblt-productivity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What channel?
- slack: "#on-week-oblt-productivity" | |
- slack: "#on-week-oblt-productivity" |
key: publish-s3-service | ||
build: | ||
env: | ||
DESTINATION_PATH: "s3://download.elasticsearch.org/synthetics-recorder/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to exclude the subfolders but use the files in the root directory. Waitign for the RElease team to provide this feature
set -eo pipefail | ||
|
||
# To help with testing the GPG signing | ||
BUILDKITE_TOKEN_SECRET=$(vault kv get -field=buildkite_token kv/ci-shared/observability-ci/buildkite-read-build-access) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an ongoing task to move away from BK API Tokens and use some opinionated contracts so we can skip this API call for the sake of simplicity. Release team is working on it
and filter easily in the s3 bucket publisher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unfortunately tests are broken :/ |
Thanks @justinkambic , I'm afraid the CI is broken, but no clue what's the error about :/ @elastic/uptime , can you help with this? |
Summary
Support Buildkite release pipeline
Implementation details
Sign the artifacts using Buildkite
How to validate this change
In Buildkite
Test
Build 26 ran a dry-run (so it signed all the artifacts but didn't upload them to s3 or GitHub releases.
Tasks
Follow-ups