Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: buildkite release pipeline #509

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

ci: buildkite release pipeline #509

wants to merge 49 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 19, 2024

Summary

Support Buildkite release pipeline

Implementation details

Sign the artifacts using Buildkite

  • Support for Macos sign
  • Support for Windows sign
  • Support for *Nix sign

How to validate this change

In Buildkite

Test

🔈 Only for Elastic employees

Build 26 ran a dry-run (so it signed all the artifacts but didn't upload them to s3 or GitHub releases.

Tasks

  • S3 bucket with some include files otherwise, it will upload even some nested folders.

Follow-ups

  • Remove Jenkins implementation

@v1v v1v changed the title Feature/configure macos run ci: buildkite release pipeline Feb 19, 2024
.buildkite/release.yml Outdated Show resolved Hide resolved
@v1v v1v marked this pull request as ready for review June 4, 2024 16:13
@v1v v1v requested a review from a team June 4, 2024 16:14
@v1v v1v self-assigned this Jun 4, 2024
notify:
- slack: "#observablt-bots"
- slack: "#on-week-oblt-productivity"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What channel?

Suggested change
- slack: "#on-week-oblt-productivity"
- slack: "#on-week-oblt-productivity"

key: publish-s3-service
build:
env:
DESTINATION_PATH: "s3://download.elasticsearch.org/synthetics-recorder/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to exclude the subfolders but use the files in the root directory. Waitign for the RElease team to provide this feature

set -eo pipefail

# To help with testing the GPG signing
BUILDKITE_TOKEN_SECRET=$(vault kv get -field=buildkite_token kv/ci-shared/observability-ci/buildkite-read-build-access)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an ongoing task to move away from BK API Tokens and use some opinionated contracts so we can skip this API call for the sake of simplicity. Release team is working on it

reakaleek
reakaleek previously approved these changes Jun 4, 2024
 and filter easily in the s3 bucket publisher
@v1v v1v requested a review from a team June 6, 2024 11:15
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v
Copy link
Member Author

v1v commented Jun 6, 2024

Unfortunately tests are broken :/

@v1v v1v mentioned this pull request Jun 6, 2024
@v1v
Copy link
Member Author

v1v commented Jul 11, 2024

Thanks @justinkambic , I'm afraid the CI is broken, but no clue what's the error about :/ @elastic/uptime , can you help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants