Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit github workflow for documentation previews #2612

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Edit github workflow for documentation previews #2612

merged 2 commits into from
Dec 11, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 7, 2023

Relates to elastic/docs#2848

Since this repo is used to generate multiple books, I set the preview-path to the top-level landing page instead of a particular book.

It seems that this change will need to be backported all the way to 8.4.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

This pull request does not have a backport label. Could you fix it @lcawl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Dec 7, 2023
@lcawl lcawl added backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify and removed backport-skip Skip automated backport with mergify labels Dec 7, 2023
@lcawl lcawl marked this pull request as ready for review December 7, 2023 21:41
@lcawl lcawl requested a review from a team as a code owner December 7, 2023 21:41
@lcawl lcawl requested a review from szabosteve December 8, 2023 17:18
karenzone
karenzone approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@lcawl lcawl merged commit 37d19c5 into elastic:main Dec 11, 2023
4 checks passed
@lcawl lcawl deleted the bk-action branch December 11, 2023 20:52
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
397dc5f 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
7461aeb 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
9cb0ee3 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
2deb36d 
(cherry picked from commit 37d19c5)
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
25d4ea5 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
7032db6 
(cherry picked from commit 37d19c5)
This was referenced Dec 11, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
c9506f9 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@lcawl @mergify
Edit github workflow for documentation previews (#2612)
a2e0b77 
(cherry picked from commit 37d19c5)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2613)
4b0fbe1 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2614)
a8e84c1 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2615)
f53a4fd 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2616)
7731f90 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2617)
52f2e03 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2618)
1f8d5e1 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2619)
4a18115 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 21, 2023
@mergify @lcawl
Edit github workflow for documentation previews (#2612) (#2620)
3252f8d 
(cherry picked from commit 37d19c5)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkammah nkammah nkammah left review comments

@karenzone karenzone karenzone approved these changes

@szabosteve szabosteve Awaiting requested review from szabosteve

Assignees
No one assigned
Labels
backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @nkammah @karenzone