Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adds authentication methods to NLP import guide #2132

Merged
merged 9 commits into from
May 10, 2022
Merged

[DOCS] Adds authentication methods to NLP import guide #2132

merged 9 commits into from
May 10, 2022

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented May 9, 2022 •
edited
Loading

Overview

Related to elastic/eland#461 and elastic/eland#462

This PR adds an Authentication methods section to the NLP import guide that lists the available methods with examples.

Preview

Authentication methods

@mergify
Copy link
Contributor

mergify bot commented May 9, 2022

This pull request does not have a backport label. Could you fix it @szabosteve? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label May 9, 2022
@szabosteve szabosteve added :ml v8.2.0 backport-8.2 Automated backport with mergify v8.3.0 labels May 9, 2022
@mergify mergify bot removed the backport-skip Skip automated backport with mergify label May 9, 2022
@szabosteve szabosteve requested a review from lcawl May 9, 2022 12:49
@szabosteve szabosteve requested a review from dolaru May 9, 2022 14:03
dolaru
dolaru approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@dolaru dolaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 (with 1 optional nit)

docs/en/stack/ml/nlp/ml-nlp-deploy-models.asciidoc Outdated Show resolved Hide resolved
@szabosteve @dolaru
Update docs/en/stack/ml/nlp/ml-nlp-deploy-models.asciidoc
334d8ba 
Co-authored-by: David Olaru <dolaru@elastic.co>
@szabosteve szabosteve merged commit bfa78f9 into elastic:main May 10, 2022
mergify bot pushed a commit that referenced this pull request May 10, 2022
@szabosteve @mergify
[DOCS] Adds authentication methods to NLP import guide (#2132)
3c7bebe 
Co-authored-by: David Olaru <dolaru@elastic.co>
(cherry picked from commit bfa78f9)
@mergify mergify bot mentioned this pull request May 10, 2022
Merged
szabosteve added a commit that referenced this pull request May 10, 2022
@mergify @dolaru @szabosteve
[DOCS] Adds authentication methods to NLP import guide (#2132) (#2133)
43e29cc 
Co-authored-by: David Olaru <dolaru@elastic.co>
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
@lcawl lcawl mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolaru dolaru dolaru approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
backport-8.2 Automated backport with mergify :ml v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @dolaru