[ML] Upgrade PyTorch to version 1.13.1 #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
approved these changes
Jan 10, 2023
| @@ -85,7 +87,8 @@ bool CCmdLineParser::parse(int argc, | |||
| return false; | |||
| } | |||
| if (vm.count("version") > 0) { | |||
| std::cerr << ver::CBuildInfo::fullInfo() << std::endl; | |||
| std::cerr << "PyTorch Version " << TORCH_VERSION << std::endl | |||
| @@ -249,14 +249,53 @@ sudo ./cmake-3.23.2-Linux-x86_64.sh --skip-license --prefix=/usr/local/cmake | |||
|
|
|||
| Please ensure `/usr/local/cmake/bin` is in your `PATH` environment variable. | |||
|
|
|||
| ### OpenSSL | |||
|
|
|||
| Python 3.10 requires OpenSSL 1.1. No other version is acceptable. | |||
There was a problem hiding this comment.
No OpenSSL 3.0?
OpenSSL 1.1.1 is LTS until 11th September 2023, hopefully we can update next time
There was a problem hiding this comment.
Yes, next time we upgrade Python presumably a different version will be needed.
But it's important to remember that we only use OpenSSL to build Python and we only use Python to build PyTorch. It's not like we use them in every build or ship them. As long as the version we've used is secure on the day we build PyTorch it's good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest version of PyTorch 1, which is 1.13.1.
The version of Python used for the build is also upgraded, from 3.7 to 3.10. Python 3.10 runs natively on macOS on ARM, and this makes the macOS ARM build much less fiddly and error-prone.