Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove versioning check for Analytics list row expansion content functional tests #98828

Merged
merged 2 commits into from
May 3, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Apr 29, 2021

Summary

This PR fixes failing tests in 7.x and 7.13 backports for Analytics list row expansion content functional tests introduced in #98678

As the version can be different on different branch/config, this PR removes the property check altogethe.

@qn895 qn895 added the :ml label Apr 29, 2021
@qn895 qn895 requested a review from pheyos April 29, 2021 19:55
@qn895 qn895 requested a review from a team as a code owner April 29, 2021 19:55
@qn895 qn895 self-assigned this Apr 29, 2021
@qn895 qn895 added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.14.0 Feature:Data Frame Analytics ML data frame analytics features test_ui_functional labels Apr 29, 2021
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented May 3, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit cbcc800 into elastic:master May 3, 2021
@qn895 qn895 deleted the ml-remove-version-check branch May 3, 2021 02:34
qn895 added a commit to kibanamachine/kibana that referenced this pull request May 3, 2021
… functional tests (elastic#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit cbcc800)
qn895 added a commit to kibanamachine/kibana that referenced this pull request May 3, 2021
… functional tests (elastic#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit cbcc800)
kibanamachine added a commit that referenced this pull request May 3, 2021
…98678) (#98795)

* [ML] Functional tests for Analytics list row expansion content (#98678)

* [ML] Remove versioning check for Analytics list row expansion content functional tests (#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit cbcc800)

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
kibanamachine added a commit that referenced this pull request May 3, 2021
…#98678) (#98794)

* [ML] Functional tests for Analytics list row expansion content (#98678)

* [ML] Remove versioning check for Analytics list row expansion content functional tests (#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit cbcc800)

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
@qn895 qn895 added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels May 3, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.13 Cherrypick failed because the selected commit (cbcc800) is empty. Did you already backport this commit?
7.x Cherrypick failed because the selected commit (cbcc800) is empty. Did you already backport this commit?

To backport manually run:
node scripts/backport --pr 98828

@qn895 qn895 added the backport:skip This commit does not require backporting label May 3, 2021
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
… functional tests (elastic#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.0 v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants