Skip to content

Commit

Permalink
[ML] Remove versioning check for Analytics list row expansion content…
Browse files Browse the repository at this point in the history
… functional tests (#98828)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
qn895 and kibanamachine authored May 3, 2021
1 parent d40adb9 commit cbcc800
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,6 @@ export default function ({ getService }: FtrProviderContext) {
},
{ section: 'progress', expectedEntries: { Phase: '8/8' } },
],
jobStats: [
{
section: 'stats',
expectedEntries: {
version: '8.0.0',
},
},
],
} as AnalyticsTableRowDetails,
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,6 @@ export default function ({ getService }: FtrProviderContext) {
},
{ section: 'progress', expectedEntries: { Phase: '4/4' } },
],
jobStats: [
{
section: 'stats',
expectedEntries: {
version: '8.0.0',
},
},
],
} as AnalyticsTableRowDetails,
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@ export default function ({ getService }: FtrProviderContext) {
},
{ section: 'progress', expectedEntries: { Phase: '8/8' } },
],
jobStats: [
{
section: 'stats',
expectedEntries: {
version: '8.0.0',
},
},
],
} as AnalyticsTableRowDetails,
},
},
Expand Down
11 changes: 4 additions & 7 deletions x-pack/test/functional/services/ml/data_frame_analytics_table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface ExpectedSectionTable {
expectedEntries: ExpectedSectionTableEntries;
}

export type AnalyticsTableRowDetails = Record<'jobDetails' | 'jobStats', ExpectedSectionTable[]>;
export type AnalyticsTableRowDetails = Record<'jobDetails', ExpectedSectionTable[]>;
export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: FtrProviderContext) {
const find = getService('find');
const retry = getService('retry');
Expand Down Expand Up @@ -395,14 +395,11 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: F
}
}

public async assertJobStatsTabContent(jobId: string, sections: ExpectedSectionTable[]) {
public async assertJobStatsTabContent(jobId: string) {
const tabSubject = 'job-stats';
await this.ensureDetailsTabOpen(jobId, tabSubject);
await this.assertDetailsSectionExists(jobId, 'stats');

for (const { section, expectedEntries } of sections) {
await this.assertRowDetailsSectionContent(jobId, section, expectedEntries);
}
await this.assertDetailsSectionExists(jobId, 'analysisStats');
}

public async assertJsonTabContent(jobId: string) {
Expand Down Expand Up @@ -431,7 +428,7 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ getService }: F
'job-messages',
]);
await this.assertJobDetailsTabContent(jobId, expectedRowDetails.jobDetails);
await this.assertJobStatsTabContent(jobId, expectedRowDetails.jobStats);
await this.assertJobStatsTabContent(jobId);
await this.assertJsonTabContent(jobId);
await this.assertJobMessagesTabContent(jobId);
});
Expand Down

0 comments on commit cbcc800

Please sign in to comment.