Replace lodash templates with static react renderer for field formatters #96048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
v8.0.0
release_note:skip
legrego
added
the
auto-backport
legrego
commented
Apr 1, 2021
| {defPairs.map((pair, idx) => ( | ||
| <Fragment key={idx}> | ||
| <dt | ||
| dangerouslySetInnerHTML={{ __html: `${pair[0]}:` }} // eslint-disable-line react/no-danger |
There was a problem hiding this comment.
Looking at this one again, I don't think it should be dangerously rendered, unless I call escape. What is your preference / what is the expected behavior?
|
@elastic/kibana-app-services how can I test the |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
Apr 3, 2021
|
@mattkime I'll verify url formatters on Monday. I had auto-merge turned on for this PR, otherwise I'd have waited to merge until verification. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the rendering logic for the
sourceandcolorfield formatters. Previous implementation useslodash.template, which requires unsafe code execution (unsafe-evalin CSP parlance). New implementation uses ReactDOM to render static markup.Resolves #94627