-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsafe-eval from our default CSP #94626
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
force-pushed
the
trial/no-script-unsafe-eval
branch
3 times, most recently
from
April 5, 2021 13:40
986d827
to
7ca4799
Compare
legrego
force-pushed
the
trial/no-script-unsafe-eval
branch
from
April 28, 2021 12:35
7ca4799
to
a7b5bb5
Compare
legrego
force-pushed
the
trial/no-script-unsafe-eval
branch
from
May 5, 2021 15:14
a7b5bb5
to
cceb9e0
Compare
legrego
force-pushed
the
trial/no-script-unsafe-eval
branch
from
May 11, 2021 18:52
cceb9e0
to
378ba9c
Compare
This was referenced May 14, 2021
@elasticmachine merge upstream |
@elasticmachine merge upstream |
⏳ Build in-progress, with failures
Failed CI Steps
History
To update your PR or re-run it, just comment with: |
2 tasks
Cross link to existing GH issue: #36311 |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will not merge in its current state. I want a general CI baseline before proceeding.
Sub-Tasks:
unsafe-eval
unsafe-eval
vega-interpreter
: Usevega-interpreter
to safely evaluate Vega expressions #98832Update: 2020-04
I am no longer actively working on this. Please follow #124484 for further updates