Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Correlations style polish in prep for release #92514

Merged
merged 8 commits into from
Feb 24, 2021

Conversation

formgeist
Copy link
Contributor

Summary

Some clean-up and polish styles for the new Correlations feature that has come up in testing.

Screenshot 2021-02-23 at 20 25 02

  • Removed the icon from the "View correlations" button
  • Moved the tabs to the FlyoutHeader
  • Removed unneeded spacers in the content
  • Reduced the filtering by callout and button
  • Made the introduction text color subdued to make it less noisy
  • Reduced ImpactBar size and extended width so the bar itself is 100
  • Changed the selected term visualization color to euiColorVis2 because the euiColorAccent is not great for visualizations.
  • Changed the latency distribution visualization color to euiColorVis1 to make it consistent with the Transactions visualization colors in the other charts.

@formgeist formgeist added Team:APM All issues that need APM UI Team support polish v7.12.0 labels Feb 23, 2021
@formgeist formgeist self-assigned this Feb 23, 2021
@formgeist formgeist requested a review from a team as a code owner February 23, 2021 20:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.0 labels Feb 23, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB -133.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @formgeist

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better!

@formgeist formgeist merged commit b131630 into elastic:master Feb 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
- Removed the icon from the "View correlations" button
- Moved the tabs to the FlyoutHeader
- Removed unneeded spacers in the content
- Reduced the filtering by callout and button
- Made the introduction text color `subdued` to make it less noisy
- Reduced ImpactBar size and extended width so the bar itself is `100`
- Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations.
- Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
- Removed the icon from the "View correlations" button
- Moved the tabs to the FlyoutHeader
- Removed unneeded spacers in the content
- Reduced the filtering by callout and button
- Made the introduction text color `subdued` to make it less noisy
- Reduced ImpactBar size and extended width so the bar itself is `100`
- Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations.
- Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #92629
7.x / #92630

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 24, 2021
- Removed the icon from the "View correlations" button
- Moved the tabs to the FlyoutHeader
- Removed unneeded spacers in the content
- Reduced the filtering by callout and button
- Made the introduction text color `subdued` to make it less noisy
- Reduced ImpactBar size and extended width so the bar itself is `100`
- Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations.
- Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.

Co-authored-by: Casper Hübertz <casper@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 24, 2021
- Removed the icon from the "View correlations" button
- Moved the tabs to the FlyoutHeader
- Removed unneeded spacers in the content
- Reduced the filtering by callout and button
- Made the introduction text color `subdued` to make it less noisy
- Reduced ImpactBar size and extended width so the bar itself is `100`
- Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations.
- Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.

Co-authored-by: Casper Hübertz <casper@elastic.co>
@formgeist formgeist deleted the apm-correlations-style-polish branch February 25, 2021 07:08
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed polish release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants