Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection] Remove unused UI Metric APIs #91620

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 17, 2021

Summary

Related to #91611

This PR removes the internal/unused UI Metric APIs.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@afharo afharo added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 17, 2021
@afharo afharo force-pushed the usage_collection/remove-unused-ui_metric-apis branch 2 times, most recently from b3f18ee to 3b20101 Compare February 17, 2021 11:56
@afharo afharo added v7.13.0 and removed v7.12.0 labels Feb 18, 2021
@afharo afharo force-pushed the usage_collection/remove-unused-ui_metric-apis branch 2 times, most recently from e74a73b to f4766d0 Compare February 22, 2021 11:45
@afharo afharo force-pushed the usage_collection/remove-unused-ui_metric-apis branch from f4766d0 to ae2290d Compare February 22, 2021 11:46
@afharo afharo marked this pull request as ready for review February 22, 2021 13:52
@afharo afharo requested review from a team as code owners February 22, 2021 13:52
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed x-pack/plugins/ingest_pipelines/public/application/services/ui_metric.ts locally. Telemetry still works.

@afharo
Copy link
Member Author

afharo commented Feb 23, 2021

@elasticmachine merge upstream

@afharo
Copy link
Member Author

afharo commented Feb 24, 2021

@elasticmachine merge upstream

@afharo afharo added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 24, 2021
@afharo afharo enabled auto-merge (squash) February 24, 2021 10:26
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 723.5KB 723.5KB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexPatternFieldEditor 79.1KB 79.3KB +212.0B
ingestPipelines 26.1KB 26.2KB +153.0B
usageCollection 10.0KB 9.8KB -257.0B
total +108.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit fd9e159 into elastic:master Feb 24, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #92606

Successful backport PRs will be merged automatically after passing CI.

@afharo afharo deleted the usage_collection/remove-unused-ui_metric-apis branch February 24, 2021 14:13
kibanamachine added a commit that referenced this pull request Feb 24, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants