Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Sessions] Fix completed session icon #92206

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[Search Sessions] Fix completed session icon #92206

merged 1 commit into from
Feb 22, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Feb 22, 2021 •
edited
Loading

Summary

Last search session indicator UI revision was done according to #89703 (comment)

But completed state icon should have been check instead of clock. 😅

This fixes a bug where we have clock icon for completed state instead of check

Screen Shot 2021-02-22 at 16 27 39

@Dosant Dosant requested a review from mdefazio February 22, 2021 15:35
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.12.0 v7.13.0 v8.0.0 labels Feb 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review February 22, 2021 17:31
@Dosant Dosant requested a review from a team as a code owner February 22, 2021 17:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

mdefazio
mdefazio approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Dosant Dosant enabled auto-merge (squash) February 22, 2021 18:00
@Dosant Dosant merged commit df8a8cb into elastic:master Feb 22, 2021
Dosant added a commit to Dosant/kibana that referenced this pull request Feb 22, 2021
@Dosant
[Search Sessions] Fix completed session icon (elastic#92206)
5c286fb
@Dosant Dosant mentioned this pull request Feb 22, 2021
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Feb 22, 2021
@Dosant
[Search Sessions] Fix completed session icon (elastic#92206)
f0174c1
@Dosant Dosant mentioned this pull request Feb 22, 2021
Merged
Dosant added a commit that referenced this pull request Feb 22, 2021
@Dosant
[Search Sessions] Fix completed session icon (#92206) (#92256)
1737067
Dosant added a commit that referenced this pull request Feb 22, 2021
@Dosant
[Search Sessions] Fix completed session icon (#92206) (#92258)
5a4483c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@mdefazio mdefazio mdefazio approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dosant @kibanamachine @elasticmachine @tsullivan @mdefazio