[Search Sessions] Disable "save session" due to timeout #90294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
commented
Feb 4, 2021
| } else { | ||
| // TODO: needed for initial open when component is not rendered yet | ||
| // fix after: https://github.com/elastic/eui/issues/4460 | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Some of the code is this pr (changes related to searchSessionIndicatorRef) is to remove this hack.
In future, we can simplify this, but we'd need EUI version with elastic/eui#4460 fix in it.
Dosant
added
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
lizozom
approved these changes
Feb 8, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Feb 8, 2021
Dosant
added a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #83640
Disable "save session" when searches are completed and
config.search.sessions.notTouchedTimeouthas passed.To avoid introducing new API and complexity around disabled state I decided to change how the disabled state works:
Before:
In some cases, we disabled the search session indicator button, but not the save session button inside the popover.
After:
Now we specifically disable the save session button instead
This also fixes a bug that you could get into a state where the popover is opened, but the search session indicator becomes disabled
Checklist
Delete any items that are not applicable to this PR.
For maintainers