Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search Sessions] Fix search session indicator in Amsterdam theme #90153

Merged
merged 1 commit into from
Feb 3, 2021
Merged

[Search Sessions] Fix search session indicator in Amsterdam theme #90153

merged 1 commit into from
Feb 3, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Feb 3, 2021 •
edited
Loading

Summary

Closes #90028
Also closes elastic/eui#4251 (because not longer needed)

Moves appendBreadcrumdExtension outside of a breadcrumb and puts it next to breadcrumb container

Screenshot 2021-02-03 at 13 11 59
Screenshot 2021-02-03 at 13 12 26
Screenshot 2021-02-03 at 13 13 13

Checklist

For maintainers

@Dosant Dosant added the Feature:Search Querying infrastructure in Kibana label Feb 3, 2021
@Dosant Dosant requested a review from mdefazio February 3, 2021 12:23
mdefazio
mdefazio approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this change.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 464.6KB 465.6KB +1012.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Feb 3, 2021
@Dosant Dosant marked this pull request as ready for review February 3, 2021 14:08
@Dosant Dosant requested review from a team as code owners February 3, 2021 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

pgayvallet
pgayvallet approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryankeairns
ryankeairns approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DeFazio's review came in before our team was assigned.

@Dosant Dosant merged commit c1ec73b into elastic:master Feb 3, 2021
Dosant added a commit to Dosant/kibana that referenced this pull request Feb 3, 2021
@Dosant
[Search Sessions] Fix search session indicator in Amsterdam theme (el…
b671872 
…astic#90153)
@Dosant Dosant mentioned this pull request Feb 3, 2021
Merged
Dosant added a commit that referenced this pull request Feb 3, 2021
@Dosant
[Search Sessions] Fix search session indicator in Amsterdam theme (#9…
7b854ee 
…0153) (#90223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@mdefazio mdefazio mdefazio approved these changes

Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@Dosant @kibanamachine @elasticmachine @ryankeairns @pgayvallet @mdefazio