Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip maps x-pack functional test #90086

Closed
wants to merge 10 commits into from
Closed

Unskip maps x-pack functional test #90086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f3fc995
fixes https://github.com/elastic/kibana/issues/74449
rashmivkulkarni Oct 20, 2020
411da9a
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 18, 2021
154ce17
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 22, 2021
a1783d8
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 25, 2021
04de479
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 27, 2021
cd06932
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 28, 2021
50550f6
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 28, 2021
ee59795
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 29, 2021
2707fa3
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Feb 2, 2021
01a9126
unskipping and adding the ID required
rashmivkulkarni Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class EMSTMSSource extends AbstractTMSSource {
return tmsService;
}

throw new Error(getErrorInfo());
throw new Error(getErrorInfo(emsTileLayerId));
}

async getDisplayName() {
Expand Down
12 changes: 4 additions & 8 deletions x-pack/test/functional/apps/maps/layer_errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import expect from '@kbn/expect';
export default function ({ getPageObjects }) {
const PageObjects = getPageObjects(['maps', 'header']);

// Failing: See https://github.com/elastic/kibana/issues/69617
describe.skip('layer errors', () => {
describe('layer errors', () => {
before(async () => {
await PageObjects.maps.loadSavedMap('layer with errors');
});
Expand Down Expand Up @@ -65,14 +64,13 @@ export default function ({ getPageObjects }) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/36011
describe.skip('EMSFileSource with missing EMS id', () => {
describe('EMSFileSource with missing EMS id', () => {
const MISSING_EMS_ID = 'idThatDoesNotExitForEMSFileSource';
const LAYER_NAME = 'EMS_vector_shapes';

it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.equal(`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}`);
expect(errorMsg).to.contain(MISSING_EMS_ID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this expect include the full text of the message. I think the only reason it doesn't currently match the product is that the text was changed while the test was skipped.

});

it('should allow deletion of layer', async () => {
Expand All @@ -88,9 +86,7 @@ export default function ({ getPageObjects }) {

it('should diplay error message in layer panel', async () => {
const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
expect(errorMsg).to.equal(
`Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}`
);
expect(errorMsg).to.contain(MISSING_EMS_ID);
});

it('should allow deletion of layer', async () => {
Expand Down