Unskip maps x-pack functional test #90086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
[Deprecated-Use Team:Presentation]Team:Geo
LeeDr
suggested changes
Feb 2, 2021
| const MISSING_EMS_ID = 'idThatDoesNotExitForEMSFileSource'; | ||
| const LAYER_NAME = 'EMS_vector_shapes'; | ||
|
|
||
| it('should diplay error message in layer panel', async () => { | ||
| const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME); | ||
| expect(errorMsg).to.equal(`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}`); | ||
| expect(errorMsg).to.contain(MISSING_EMS_ID); |
There was a problem hiding this comment.
I'd rather have this expect include the full text of the message. I think the only reason it doesn't currently match the product is that the text was changed while the test was skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #36011
part of #89788