[Enterprise Search] Minor Elastic Cloud setup guide instructions fixes #89620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
bug
cee-chen
changed the title
cee-chen
commented
Jan 28, 2021
Comment on lines
+37
to
+46
| {i18n.translate( | ||
| 'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText', | ||
| { defaultMessage: 'edit your deployment' } | ||
| )} | ||
| </EuiLink> | ||
| ) : ( | ||
| 'Visit the Elastic Cloud console' | ||
| i18n.translate( | ||
| 'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText', | ||
| { defaultMessage: 'edit your deployment' } | ||
| ) |
There was a problem hiding this comment.
I thought about DRYing this out but was lazy about it, would prefer to address later if possible since there's some time considerations in getting this fix in
| @@ -34,10 +34,16 @@ export const CloudSetupInstructions: React.FC<Props> = ({ productName, cloudDepl | |||
| values={{ | |||
| editDeploymentLink: cloudDeploymentLink ? ( | |||
| <EuiLink href={cloudDeploymentLink + '/edit'} target="_blank"> | |||
| edit your deployment | |||
| {i18n.translate( | |||
| 'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText', | |||
There was a problem hiding this comment.
Is the 1 in instruction1LinkText intentional?
There was a problem hiding this comment.
Yes, they are all intentional in that they match the parent i18n ID, e.g.:
xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1xpack.enterpriseSearch.setupGuide.cloud.step3.instruction1xpack.enterpriseSearch.setupGuide.cloud.step5.instruction1
I numbered them in case we ever update instruction copy to have multiple paragraphs, then we can just do instruction1, instruction2, etc. Not 100% sure if that's correct as a best practice, but it's the way it currently is already
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
JasonStoltz
approved these changes
Jan 29, 2021
This was referenced Jan 29, 2021
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Jan 29, 2021
elastic#89620) * Fix Cloud instructions copy when cloudDeploymentLink is missing * Fix missing i18n translations on copy nested within links Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cee-chen
pushed a commit
that referenced
this pull request
Jan 29, 2021
#89620) (#89761) * Fix Cloud instructions copy when cloudDeploymentLink is missing * Fix missing i18n translations on copy nested within links Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cee-chen
pushed a commit
that referenced
this pull request
Jan 29, 2021
#89620) (#89760) * Fix Cloud instructions copy when cloudDeploymentLink is missing * Fix missing i18n translations on copy nested within links Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Matt found a bug with our Cloud instructions slated to ship in 7.11: If
cloudDeploymentLinkis empty/not passed in, the resulting message isbut should be
Checklist