Skip to content

Commit

Permalink
[Enterprise Search] Minor Elastic Cloud setup guide instructions fixes (
Browse files Browse the repository at this point in the history
#89620) (#89761)

* Fix Cloud instructions copy when cloudDeploymentLink is missing

* Fix missing i18n translations on copy nested within links

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
Constance and kibanamachine authored Jan 29, 2021
1 parent 2beeccc commit f7fb1c5
Showing 1 changed file with 16 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,16 @@ export const CloudSetupInstructions: React.FC<Props> = ({ productName, cloudDepl
values={{
editDeploymentLink: cloudDeploymentLink ? (
<EuiLink href={cloudDeploymentLink + '/edit'} target="_blank">
edit your deployment
{i18n.translate(
'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText',
{ defaultMessage: 'edit your deployment' }
)}
</EuiLink>
) : (
'Visit the Elastic Cloud console'
i18n.translate(
'xpack.enterpriseSearch.setupGuide.cloud.step1.instruction1LinkText',
{ defaultMessage: 'edit your deployment' }
)
),
}}
/>
Expand Down Expand Up @@ -76,7 +82,10 @@ export const CloudSetupInstructions: React.FC<Props> = ({ productName, cloudDepl
href={`${ENT_SEARCH_DOCS_PREFIX}/configuration.html`}
target="_blank"
>
configurable options
{i18n.translate(
'xpack.enterpriseSearch.setupGuide.cloud.step3.instruction1LinkText',
{ defaultMessage: 'configurable options' }
)}
</EuiLink>
),
}}
Expand Down Expand Up @@ -118,7 +127,10 @@ export const CloudSetupInstructions: React.FC<Props> = ({ productName, cloudDepl
href={`${CLOUD_DOCS_PREFIX}/ec-configure-index-management.html`}
target="_blank"
>
configure an index lifecycle policy
{i18n.translate(
'xpack.enterpriseSearch.setupGuide.cloud.step5.instruction1LinkText',
{ defaultMessage: 'configure an index lifecycle policy' }
)}
</EuiLink>
),
}}
Expand Down

0 comments on commit f7fb1c5

Please sign in to comment.