Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrations v2: fix snapshot builds #89541

Merged
merged 2 commits into from
Jan 28, 2021
Merged

migrations v2: fix snapshot builds #89541

merged 2 commits into from
Jan 28, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Jan 28, 2021 •
edited
Loading

Summary

Fixes #89482
Related #89056

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 labels Jan 28, 2021
@rudolf rudolf marked this pull request as ready for review January 28, 2021 11:02
@rudolf rudolf requested a review from a team as a code owner January 28, 2021 11:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 8534faf into elastic:master Jan 28, 2021
@rudolf rudolf deleted the migrationsv2-fix-snapshot-builds branch January 28, 2021 13:06
@EricDavisX EricDavisX mentioned this pull request Jan 28, 2021
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 89541 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 1, 2021
@rudolf rudolf added the v7.12.0 label Feb 1, 2021
rudolf added a commit to rudolf/kibana that referenced this pull request Feb 1, 2021
@rudolf
migrations v2: fix snapshot builds (elastic#89541)
8fb8098 
* migrations v2: fix snapshot builds

* Revert "Fix sharing saved objects phase 2 CI (elastic#89056)"

This reverts commit 8263d47.
This was referenced Feb 1, 2021
Closed
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

rudolf added a commit to rudolf/kibana that referenced this pull request Feb 8, 2021
@rudolf
migrations v2: fix snapshot builds (elastic#89541)
bc59b4f 
* migrations v2: fix snapshot builds

* Revert "Fix sharing saved objects phase 2 CI (elastic#89056)"

This reverts commit 8263d47.
@rudolf rudolf mentioned this pull request Feb 8, 2021
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

rudolf added a commit that referenced this pull request Feb 9, 2021
@rudolf @kibanamachine
[7.x] Backport v2 SO migrations, disabled in FTR tests (#89297) (#89903)
735d9a9 
* Enable v2 so migrations, disable in FTR tests (#89297)

* Enable v2 so migrations, disable in FTR tests

* Disable v2 migrations for ui_settings integration tests

* Disable v2 migrations for reporting without serucity api integration test
# Conflicts:
#	test/common/config.js

* migrations v2: fix snapshot builds (#89541)

* migrations v2: fix snapshot builds

* Revert "Fix sharing saved objects phase 2 CI (#89056)"

This reverts commit 8263d47.

* Fix documentMigrator for snapshot releases (#89936)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations v2: Ensure index is lowercase
4 participants
@rudolf @elasticmachine @kibanamachine @pgayvallet