Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Montoring] Use fetchClustersRange #87882

Merged
merged 2 commits into from
Jan 12, 2021
Merged

[Montoring] Use fetchClustersRange #87882

merged 2 commits into from
Jan 12, 2021

Conversation

chrisronline
Copy link
Contributor

Relates to #85841

This is a regression as the missing monitoring data alert isn't using the right base class properties to work properly.

See #78208 for testing steps, but keep in mind #83839 changed this alert to only apply to ES.

@chrisronline chrisronline self-assigned this Jan 11, 2021
@chrisronline chrisronline requested a review from a team January 11, 2021 17:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline mentioned this pull request Jan 11, 2021
Closed
23 tasks
igoristic
igoristic approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 04d4d85 into elastic:master Jan 12, 2021
@chrisronline chrisronline deleted the monitoring/missing_monitoring_data_fix branch January 12, 2021 16:47
This was referenced Jan 12, 2021
Merged
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Use fetchClustersRange (elastic#87882)
ff208f5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Use fetchClustersRange (elastic#87882)
2c4d6ce 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Use fetchClustersRange (#87882) (#88040)
0dbc45e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit that referenced this pull request Jan 12, 2021
@chrisronline @kibanamachine
Use fetchClustersRange (#87882) (#88041)
78855c6 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:fix review Team:Monitoring Stack Monitoring team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic