[ILM] Delete index_codec option if disabled in UI

[alisonelizabeth]

Fixes #87219

I could not reproduce on 7.10, so I think this was introduced at some point during the 7.11 release cycle, possibly from #83077.

How to test:

1. Navigate to ILM and create a policy.
2. Enable the force merge action for the hot phase. Specify the number of segments and enable the "Compress stored fields" option.
3. Enable the force merge action for the warm phase. Specify the number of segments and enable the "Compress stored fields" option.
4. Save the policy.
5. Reopen the policy and disable the "Compress stored fields" option for both hot and warm phases.
6. Save the policy.
7. Reopen the policy and verify the "Compress stored fields" options are disabled.

[alisonelizabeth]

I wasn't sure how to test this logic in the UI and if there's any additional changes required here too.

[jloleysens]

Yeah, it is a bit more tricky to fully test in the UI since we have to interact with the component and submit the form to catch the network request that would have been made and then make assertions against that payload. Kind of like this

kibana/x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts

Line 119 in b99ca96

test('setting all values', async () => {

In this case I guess we'd make a policy that has this enabled, submit a request, check that it is there, then disable and send the request again. Although that might require wrestling with any routing that happens too.

For now, I think having a unit test for the serialisation is good, since we know the toggle can actually set the value. The trickier (more bug prone) part of the serialiser is removing values that have been unset.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[jloleysens]

@elasticmachine merge upstream

[jloleysens]

@elasticmachine merge upstream

[jloleysens]

Great work @alisonelizabeth ! Tested locally and removing codec works.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 40c2667

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
indexLifecycleManagement	249.7KB	249.8KB	+104.0B

Distributable file count

id	before	after	diff
default	47262	48025	+763

History

• 💚 Build #96940 succeeded 6758a0e
• 💔 Build #96850 failed bbae99c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream