Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Do not send keep_alive after a session is sent to background #85350

Closed

Conversation

lukasolson
Copy link
Member

Summary

After a search session is sent to background, we no longer want to send the keep_alive parameter in our subsequent polling requests, because doing so will override the keep_alive we set when sending to background. This PR updates the search strategy behavior with this change.

Checklist

For maintainers

@lukasolson lukasolson added review Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Project:AsyncSearch Background search, partial results, async search services. labels Dec 8, 2020
@lukasolson lukasolson self-assigned this Dec 8, 2020
@lukasolson lukasolson requested a review from a team as a code owner December 8, 2020 22:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I wonder if we can somehow test for the race condition where the save that increases the keepalive happens, but then a search polling request that was triggered before the save comes in without isStored and reduces the keepalive irreversibly.

@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@lukasolson
Copy link
Member Author

We also need to think about the case where the search completes & the user stays on screen for awhile before sending to background.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47241 48001 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Search Querying infrastructure in Kibana Project:AsyncSearch Background search, partial results, async search services. release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants