Design cleanup details panel #85044
Merged
Design cleanup details panel #85044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 4, 2020 10:56
…g + fixed responsive issues on flex items
…f filter icon + value
hbharding
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
7 tasks
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
hbharding
added a commit
to hbharding/kibana
that referenced
this pull request
Dec 4, 2020
* cleanup overlay panel. fixed sizes, variable panel height, responsive breakpoint * cleanup metrics tab. use EuiFlexGrid + ChartSizeArray for chart sizing + fixed responsive issues on flex items * cleanup metadata tab. disabled responsive table and fixed alignment of filter icon + value * cleanup logs search. adjusted button size + spacing * fix responsivness on array values * remove responsive behavior on search + view-in-logs button * fix typecheck
hbharding
added a commit
that referenced
this pull request
Dec 7, 2020
* cleanup overlay panel. fixed sizes, variable panel height, responsive breakpoint * cleanup metrics tab. use EuiFlexGrid + ChartSizeArray for chart sizing + fixed responsive issues on flex items * cleanup metadata tab. disabled responsive table and fixed alignment of filter icon + value * cleanup logs search. adjusted button size + spacing * fix responsivness on array values * remove responsive behavior on search + view-in-logs button * fix typecheck Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I fixed several items and did some small refactors, described below, to better align with the intended design. I found some other problems which I couldn't fix on my own, but I'll address these in #85061.
Some global things
responsive={false}on EuiFlexGroup when the default built-in responsive behavior is not necessary! :)EuiPageBackgroundColor.Metrics Tab
Logs Tab
Metadata Tab
Responsive Layout