[Fleet] add readme to uploaded package info and fix images #84944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Dec 3, 2020
Clarify EPR types relationship with package spec. i.e. what required properties it makes optional, what properties it adds, which property types it changes, etc. 3 TS errors and I think they're all expected to be fixed by elastic#84944 ERROR x-pack failed x-pack/plugins/fleet/public/applications/fleet/hooks/use_package_icon_type.ts:45:66 - error TS2339: Property 'path' does not exist on type 'PackageSpecIcon'. 45 const localIconSrc = Array.isArray(svgIcons) && (svgIcons[0].path || svgIcons[0].src); ~~~~ x-pack/plugins/fleet/public/applications/fleet/sections/epm/screens/detail/overview_panel.tsx:13:24 - error TS2339: Property 'readme' does not exist on type 'PackageInfo'. 13 const { screenshots, readme, name, version } = props; ~~~~~~ x-pack/plugins/fleet/public/applications/fleet/sections/epm/screens/detail/overview_panel.tsx:18:36 - error TS2322: Type 'PackageSpecScreenshot[] | (PackageSpecScreenshot[] & RegistryImage[])' is not assignable to type 'RegistryImage[]'. Type 'PackageSpecScreenshot[]' is not assignable to type 'RegistryImage[]'. Property 'path' is missing in type 'PackageSpecScreenshot' but required in type 'RegistryImage'. 18 {screenshots && <Screenshots images={screenshots} />} ~~~~~~ x-pack/plugins/fleet/common/types/models/epm.ts:115:3 115 path: string; ~~~~ 'path' is declared here. x-pack/plugins/fleet/public/applications/fleet/sections/epm/screens/detail/screenshots.tsx:14:3 14 images: ScreenshotItem[]; ~~~~~~ The expected type comes from property 'images' which is declared here on type 'IntrinsicAttributes & ScreenshotProps' Found 3 errors.
1 task
neptunian
added
the
release_note:skip
jfsiii
reviewed
Dec 3, 2020
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Dec 3, 2020
|
@elasticmachine merge upstream |
|
Ran merge to re-test. Looked like unrelated failure |
|
@elasticmachine merge upstream |
neptunian
force-pushed
the
84583-add-info-uploaded-packages
branch
from
c9df235
to
52d812e
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Dec 4, 2020
…84944) * use the relative src instead of path for package images * add readme to package info for uploaded packages * let toPackageImage take the image object and check path if no src * use variable
neptunian
added a commit
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84583
readmeproperty and path if exists to package infosrcover thepathpropertyTest
[screenshot coming]