[TSVB] Wrong x-axis formatting if "dateFormat" configuration property is not specified #84899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not specified
alexwizp
added
Feature:TSVB
|
@elasticmachine merge upstream |
stratoula
approved these changes
Dec 4, 2020
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 4, 2020
… is not specified (elastic#84899) * [TSVB] Wrong x-axis formatting if "dateFormat" configuration property is not specified * Update create_xaxis_formatter.js Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 4, 2020
… is not specified (elastic#84899) * [TSVB] Wrong x-axis formatting if "dateFormat" configuration property is not specified * Update create_xaxis_formatter.js Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js
alexwizp
added a commit
that referenced
this pull request
Dec 4, 2020
… is not specified (#84899) (#85032) * [TSVB] Wrong x-axis formatting if "dateFormat" configuration property is not specified * Update create_xaxis_formatter.js Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js
alexwizp
added a commit
that referenced
this pull request
Dec 4, 2020
… is not specified (#84899) (#85031) * [TSVB] Wrong x-axis formatting if "dateFormat" configuration property is not specified * Update create_xaxis_formatter.js Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSVB to calculate labels for the x-axis uses two configuration properties:
dateFormatanddateFormat:scaled. We faced with a problem when one of property is not configured. Instead of using a default format we showtimestampvalues:on the other hand, all of our classical visualizations correctly deal with that case and use a default formatter from momentjs library. See e.g. Area visualization:
TSVB should work the same
In my PR I removed one If statement responsible for that. I can't find any reason why it was added
Steps to reproduce:
Open Stack Management -> Advanced Settings and cleanup
dateFormatpropertyOpen TSVB visualization and see x-axis labels on Time Series tab
Expected behavior: I expect to see user friendly labels instead of timestamp