-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Convert APM-related server files that read from _source to typescript #84829
[Monitoring] Convert APM-related server files that read from _source to typescript #84829
Conversation
Pinging @elastic/stack-monitoring (Team:Monitoring) |
@chrisronline const eventsTotalFirst = firstStats?.metrics?.libbeat?.pipeline?.events?.total ?? null; And, maybe the types can also indicate which of these might be undefined |
Excellent point @igoristic. I don't actually know what can be defined and what might be undefined. We should probably be on the safe side |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Great job on converting these 🏆
…to typescript (elastic#84829) * get_apms converted * More APM ones * get_beat_summary * Fix test * This is optional * Fix tests * Be more safe
Relates to #84370
This PR updates a couple source files used for APM monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864
I'm going to try and do one PR for each stack product to avoid long reviews.