[Enterprise Search] Move schema types to shared #84822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the Schema types in Workplace Search as well, so moving these to shared. Also, we have a component called IndexingStatus so reverting to the prefixed IIndexingStatus interface name
scottybollinger
added
Feature:Plugins
release_note:skip
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Dec 2, 2020
* Move schema types to shared We use the Schema types in Workplace Search as well, so moving these to shared. Also, we have a component called IndexingStatus so reverting to the prefixed IIndexingStatus interface name * Fix misspelled interface
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Dec 2, 2020
Added here: elastic#84822
scottybollinger
added a commit
that referenced
this pull request
Dec 2, 2020
* Move schema types to shared We use the Schema types in Workplace Search as well, so moving these to shared. Also, we have a component called IndexingStatus so reverting to the prefixed IIndexingStatus interface name * Fix misspelled interface
JasonStoltz
reviewed
Dec 3, 2020
| @@ -4,6 +4,29 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| export type SchemaTypes = 'text' | 'number' | 'geolocation' | 'date'; | |||
There was a problem hiding this comment.
Great timing, I need these in my current PR.
scottybollinger
added a commit
that referenced
this pull request
Dec 3, 2020
* Initial copy/paste of component tree
Only does linting changes and:
- lodash imports
- Replace unescaped apostrophes with '
- Fix ternary function call to if block:
if (isAdding) {
actions.onSchemaSetFormErrors(errors);
} else {
actions.onSchemaSetError({ flashMessages: { error: errors } });
}
* Remove local flash messages from component
* Update paths
- Adds getReindexJobRoute method to routes
- Repalces legacy Rails routes helper with hard-coded paths
* Add types and constants
* Update paths
* Replace local flash message logic with gobal
* Update with newly added types
Added here: #84822
* Update server routes
* Replace Rails http with kibana http
* Set percentage to 0 when updating
Without this, the IndexingStatus never shows.
* Fix route paths
* Fix server route validation
The empty object was breaking the UI since `schema.object({})` is actually an empty object. This is more explicit and correct.
* Add i18n
* Make sure i18n key is unique
* Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the Schema types in Workplace Search as well, so moving these to shared. Also, we have a component called
IndexingStatusso reverting to the prefixedIIndexingStatusinterface name