[Ingest Node Pipelines] Integrate painless autocomplete #84554

alisonelizabeth · 2020-11-30T17:19:43Z

This PR integrates painless autocompletion in the Ingest Node Pipelines UI.

Continuation of #80577.

How to test

Verify autocomplete for the "Condition" editor (appears for all processors)
Verify autocomplete for the "Source" editor which appears only for the script processor. Autocomplete should only be enabled if the "Language" field is left blank (defaults to painless), or the user explicitly sets the field to "painless".

Release note

The Ingest Node Pipelines UI now supports autocompletion for the Painless language when defining a condition for a processor, as well as when defining a source for a script processor.

elasticmachine · 2020-11-30T17:29:25Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth · 2020-12-02T20:59:06Z

@elasticmachine merge upstream

jloleysens · 2020-12-03T08:57:18Z

@elasticmachine merge upstream

jloleysens

Great work @alisonelizabeth ! This is an awesome enhancement for Ingest Pipelines.

After testing locally I'd like to highlight a couple of things:

I noticed slight sluggishness on the inputs in the script processor form. I tracked it down to two places one of which I commented about in the code. The other is due to AddProcessorForm and EditProcessorForm components not being wrapped in React.memo causing them to re-render for every form change. I am happy for you to make these changes in a separate PR, so I won't block here, but I think it would be great address these rendering issues 💪

Another thing, unrelated to this PR is that autocomplete kicks in for string and boolean values

This might be something you are already aware of, but I just wanted to share as it felt a little bit weird to get class name suggestions while typing out a string value 😅

I think these are both things we can address here or in another PR, but I don't think it is necessary to block this contribution on those issues.

jloleysens · 2020-12-03T08:53:11Z

...cation/components/pipeline_processors_editor/components/processor_form/processors/script.tsx

@@ -122,6 +129,17 @@ const fieldsConfig: FieldsConfig = {

 export const Script: FormFieldsComponent = ({ initialFieldValues }) => {
  const [showId, setShowId] = useState(() => !!initialFieldValues?.id);
+  const [scriptLanguage, setScriptLanguage] = useState<string>('plaintext');


jloleysens · 2020-12-03T09:29:55Z

...cation/components/pipeline_processors_editor/components/processor_form/processors/script.tsx

@@ -122,6 +129,17 @@ const fieldsConfig: FieldsConfig = {

 export const Script: FormFieldsComponent = ({ initialFieldValues }) => {
  const [showId, setShowId] = useState(() => !!initialFieldValues?.id);
+  const [scriptLanguage, setScriptLanguage] = useState<string>('plaintext');
+
+  const [{ fields }] = useFormData();


Suggested change

const [{ fields }] = useFormData();

const [{ fields }] = useFormData({ watch: 'fields.lang' });

This will make sure we don't re-render unless needed otherwise there is some sluggishness on text inputs.

…nes/painless_autocomplete

alisonelizabeth · 2020-12-03T19:16:52Z

Thanks for the review @jloleysens!

I noticed slight sluggishness on the inputs in the script processor form. I tracked it down to two places one of which I commented about in the code. The other is due to AddProcessorForm and EditProcessorForm components not being wrapped in React.memo causing them to re-render for every form change.

Great catches! I addressed the first issue; the second I'd like to handle in a follow-up PR.

Another thing, unrelated to this PR is that autocomplete kicks in for string and boolean values

👍 I will fix this. Seb also has provided some feedback on the autocomplete that I will incorporate with this in a separate PR.

kibanamachine · 2020-12-03T20:59:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8380de2

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ingestPipelines`	819.5KB	820.6KB	+1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ingestPipelines`	35.0KB	35.2KB	+165.0B

History

💚 Build #91643 succeeded 6f417e2
💚 Build #91525 succeeded 2152ed8
💚 Build #90802 succeeded 8e0fdbc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

)

* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...

integrate painless autocomplete with ingest node pipelines

8e0fdbc

alisonelizabeth added release_note:enhancement v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management v7.11.0 labels Nov 30, 2020

alisonelizabeth marked this pull request as ready for review November 30, 2020 17:29

alisonelizabeth requested a review from a team as a code owner November 30, 2020 17:29

alisonelizabeth requested a review from jloleysens November 30, 2020 17:29

Merge branch 'master' into ingest_pipelines/painless_autocomplete

2152ed8

Merge branch 'master' into ingest_pipelines/painless_autocomplete

6f417e2

jloleysens approved these changes Dec 3, 2020

View reviewed changes

alisonelizabeth added 2 commits December 3, 2020 13:54

Merge branch 'master' of github.com:elastic/kibana into ingest_pipeli…

c4f44e3

…nes/painless_autocomplete

address review feedback

8380de2

alisonelizabeth merged commit 5c88a3c into elastic:master Dec 3, 2020

alisonelizabeth deleted the ingest_pipelines/painless_autocomplete branch December 3, 2020 21:18

alisonelizabeth mentioned this pull request Dec 3, 2020

[7.x] [Ingest Node Pipelines] Integrate painless autocomplete (#84554) #84952

Merged

alisonelizabeth added a commit that referenced this pull request Dec 4, 2020

[Ingest Node Pipelines] Integrate painless autocomplete (#84554) (#84952

0e5e413

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest Node Pipelines] Integrate painless autocomplete #84554

[Ingest Node Pipelines] Integrate painless autocomplete #84554

alisonelizabeth commented Nov 30, 2020 •

edited

Loading

elasticmachine commented Nov 30, 2020

alisonelizabeth commented Dec 2, 2020

jloleysens commented Dec 3, 2020

jloleysens left a comment •

edited

Loading

jloleysens Dec 3, 2020

jloleysens Dec 3, 2020

alisonelizabeth commented Dec 3, 2020

kibanamachine commented Dec 3, 2020

	const [{ fields }] = useFormData();
	const [{ fields }] = useFormData({ watch: 'fields.lang' });

[Ingest Node Pipelines] Integrate painless autocomplete #84554

[Ingest Node Pipelines] Integrate painless autocomplete #84554

Conversation

alisonelizabeth commented Nov 30, 2020 • edited Loading

How to test

Release note

elasticmachine commented Nov 30, 2020

alisonelizabeth commented Dec 2, 2020

jloleysens commented Dec 3, 2020

jloleysens left a comment • edited Loading

Choose a reason for hiding this comment

jloleysens Dec 3, 2020

Choose a reason for hiding this comment

jloleysens Dec 3, 2020

Choose a reason for hiding this comment

alisonelizabeth commented Dec 3, 2020

kibanamachine commented Dec 3, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

alisonelizabeth commented Nov 30, 2020 •

edited

Loading

jloleysens left a comment •

edited

Loading