[CCR] Fix row actions in follower index and auto-follow pattern tables #84433

yuliacech · 2020-11-26T16:38:39Z

Fixes #84236, #63361, #63441 (all related issues).

Summary

This PR changes how providers for follower index and auto-follow pattern actions wrap the components.

Before a provider would wrap around span element rendered in a custom table action. That way a modal (that the action displays) is mounted inside the rendered action.
A recent update to EUI now causes table action popup to auto-close after an action was clicked and thus the modal is closed short after the click too (Similar issue #70383 in ML).

This PR proposes to use providers to wrap around tables, so that the modal would be mounted after the table (and outside of row action buttons). Follower index table has 3 different action providers which can be grouped together for easier use.

How to test

Start Kibana with yarn start
Start 'local' cluster with yarn es snapshot --license=trial
Start 'remote' cluster with yarn es snapshot --license=trial -E cluster.name=europe -E transport.port=9400 in a separate terminal tab.
- Alternatively, checkout elasticsearch repo in a folder adjacent to Kibana and use yarn es source --license=trial -E cluster.name=europe -E transport.port=9400
Index a document into my-leader-index on 'remote' cluster with curl -X PUT http://elastic:changeme@localhost:9201/my-leader-index --data '{"settings":{"number_of_shards":1,"soft_deletes.enabled":true}}' --header "Content-Type: application/json"
Navigate to 'Stack Management' -> 'Remote Clusters' and add a remote cluster available at 127.0.0.1:9400
Navigate tot 'Stack Management' -> 'Cross-Cluster Replication' and add a follower index (for my-leader-index)and an auto-follow pattern

Release Note

Fixes issues in Cross-Cluster Replication app where pausing/resuming index replication, unfollowing leader index or deleting an auto-follow pattern was not possible from table actions.

…auto-closing

yuliacech · 2020-11-26T17:48:08Z

This PR will need a 7.10 backport as the issue is reproducible on 7.10 branch

yuliacech · 2020-11-30T10:18:30Z

@elasticmachine merge upstream

elasticmachine · 2020-11-30T10:18:43Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth

Nice work @yuliacech! Closing 3 issues in one PR 🎉 . Tested locally and confirmed fix. Are there any tests that should be added for this?

alisonelizabeth · 2020-12-01T13:32:50Z

...on/public/app/components/follower_index_actions_providers/follower_index_actions_provider.js

+ */
+
+import { FollowerIndexPauseProvider } from './follower_index_pause_provider';
+import React from 'react';


nit: move react import to top

alisonelizabeth · 2020-12-01T13:36:00Z

x-pack/plugins/cross_cluster_replication/public/app/components/index.js

-export { FollowerIndexPauseProvider } from './follower_index_pause_provider';
-export { FollowerIndexResumeProvider } from './follower_index_resume_provider';
-export { FollowerIndexUnfollowProvider } from './follower_index_unfollow_provider';
+export { FollowerIndexPauseProvider } from './follower_index_actions_providers/follower_index_pause_provider';


nit: I haven't looked too closely at the folder structure of CCR, but we typically have an index.js file to export files in a directory. In this case, follower_index_actions_providers would have an index.js file, where you would export FollowerIndexPauseProvider, FollowerIndexResumeProvider, etc. Then, here, you could export everything from ./follower_index_actions_providers.

thanks for the tip, @alisonelizabeth ! I added index.js file ~~actually removed the individual imports for pause, resume and unfollow providers, since they are not needed anymore~~ and providers can now be imported from the same folder.

elasticmachine · 2020-12-01T16:09:44Z

Pinging @elastic/kibana-accessibility (Project:Accessibility)

cjcenizal · 2020-12-01T16:10:40Z

Great work @yuliacech! FWIW, this should be considered a bug fix PR and will need a release note, since it's fixing some issues noticed back in April.

alisonelizabeth · 2020-12-01T16:16:35Z

Good catch @cjcenizal!

This PR will need a 7.10 backport as the issue is reproducible on 7.10 branch

@yuliacech I also forgot to ask, based on this comment^, can you add the 7.10.2 tag?

…x_actions_provider imports

kibanamachine · 2020-12-01T18:33:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ec360bf

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`crossClusterReplication`	159	161	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`crossClusterReplication`	357.7KB	356.7KB	-962.0B

History

💔 Build #91093 failed 63acf37
💚 Build #90636 succeeded 33e9d36
💚 Build #90468 succeeded 37a038c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#84433) * Fixed auto follow actions * Created a provider for all follower index table actions to fix modal auto-closing * Moved i18n texts into a const to avoid duplication * Removed unnecessary imports and added index.js file for follower_index_actions_provider imports * Fixed wrong imports deletion * Fixed wrong imports deletion Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

#84433) (#84704) * Fixed auto follow actions * Created a provider for all follower index table actions to fix modal auto-closing * Moved i18n texts into a const to avoid duplication * Removed unnecessary imports and added index.js file for follower_index_actions_provider imports * Fixed wrong imports deletion * Fixed wrong imports deletion Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) endpoint telemetry cloned endpoint tests (elastic#81498) [Fleet] Handler api key creation errors when Fleet Admin is invalid (elastic#84576)

* master: (72 commits) Make alert status fetching more resilient (elastic#84676) [APM] Refactor hooks and context (elastic#84615) Added word break styles to the texts in the item details card. (elastic#84654) [Search] Disable "send to background" when auto-refresh is enabled (elastic#84106) Add readme for new palette service (elastic#84512) Make all providers to preserve original URL when session expires. (elastic#84229) [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) ...

#84433) (#84705) * Fixed auto follow actions * Created a provider for all follower index table actions to fix modal auto-closing * Moved i18n texts into a const to avoid duplication * Removed unnecessary imports and added index.js file for follower_index_actions_provider imports * Fixed wrong imports deletion * Fixed wrong imports deletion Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

yuliacech added 3 commits November 26, 2020 13:16

Fixed auto follow actions

aea3c44

Created a provider for all follower index table actions to fix modal …

256816b

…auto-closing

Moved i18n texts into a const to avoid duplication

37a038c

yuliacech added Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0 labels Nov 26, 2020

Merge branch 'master' into ccr_fix

33e9d36

yuliacech marked this pull request as ready for review November 30, 2020 10:18

yuliacech requested a review from a team as a code owner November 30, 2020 10:18

yuliacech requested a review from alisonelizabeth November 30, 2020 16:15

alisonelizabeth approved these changes Dec 1, 2020

View reviewed changes

cjcenizal added the Project:Accessibility label Dec 1, 2020

Removed unnecessary imports and added index.js file for follower_inde…

63acf37

…x_actions_provider imports

yuliacech added release_note:fix v7.10.2 and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 1, 2020

yuliacech added 2 commits December 1, 2020 17:51

Fixed wrong imports deletion

926da54

Fixed wrong imports deletion

ec360bf

yuliacech merged commit 4ae84a0 into elastic:master Dec 1, 2020

yuliacech mentioned this pull request Dec 1, 2020

[7.x] [CCR] Fix row actions in follower index and auto-follow pattern tables (#84433) #84704

Merged

yuliacech mentioned this pull request Dec 1, 2020

[7.10] [CCR] Fix row actions in follower index and auto-follow pattern tables (#84433) #84705

Merged

This was referenced Dec 2, 2020

CCR actions aren't keyboard accessible #63361

Closed

[CCR] IE 11 auto-follow pattern table action not triggered #63441

Closed

yuliacech deleted the ccr_fix branch February 24, 2021 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCR] Fix row actions in follower index and auto-follow pattern tables #84433

[CCR] Fix row actions in follower index and auto-follow pattern tables #84433

yuliacech commented Nov 26, 2020 •

edited

Loading

yuliacech commented Nov 26, 2020

yuliacech commented Nov 30, 2020

elasticmachine commented Nov 30, 2020

alisonelizabeth left a comment

alisonelizabeth Dec 1, 2020

alisonelizabeth Dec 1, 2020

yuliacech Dec 1, 2020 •

edited

Loading

elasticmachine commented Dec 1, 2020

cjcenizal commented Dec 1, 2020

alisonelizabeth commented Dec 1, 2020

kibanamachine commented Dec 1, 2020

[CCR] Fix row actions in follower index and auto-follow pattern tables #84433

[CCR] Fix row actions in follower index and auto-follow pattern tables #84433

Conversation

yuliacech commented Nov 26, 2020 • edited Loading

Summary

How to test

Release Note

yuliacech commented Nov 26, 2020

yuliacech commented Nov 30, 2020

elasticmachine commented Nov 30, 2020

alisonelizabeth left a comment

Choose a reason for hiding this comment

alisonelizabeth Dec 1, 2020

Choose a reason for hiding this comment

alisonelizabeth Dec 1, 2020

Choose a reason for hiding this comment

yuliacech Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Dec 1, 2020

cjcenizal commented Dec 1, 2020

alisonelizabeth commented Dec 1, 2020

kibanamachine commented Dec 1, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

yuliacech commented Nov 26, 2020 •

edited

Loading

yuliacech Dec 1, 2020 •

edited

Loading