Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes code ownership from kibana-telemetry to kibana-core #84281

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Changes code ownership from kibana-telemetry to kibana-core #84281

merged 2 commits into from
Nov 24, 2020

Conversation

TinaHeiligers
Copy link
Contributor

Also adds kibana-core to localization folders

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:KibanaTelemetry v8.0.0 labels Nov 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-localization (Team:Localization)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@TinaHeiligers TinaHeiligers added v7.11.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0 and removed v7.11.0 v8.0.0 labels Nov 24, 2020
joshdover
joshdover approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit: could we move these sections to be right after the other Kibana Core CODEOWNERS?

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Nov 24, 2020 •
edited
Loading

One small nit: could we move these sections to be right after the other Kibana Core CODEOWNERS?

@joshdover Done

@TinaHeiligers TinaHeiligers merged commit a1b568b into elastic:master Nov 24, 2020
@TinaHeiligers TinaHeiligers deleted the update-CODEOWNERS branch November 24, 2020 23:32
@TinaHeiligers TinaHeiligers mentioned this pull request Nov 25, 2020
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 84281 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Nov 26, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdover joshdover joshdover approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Telemetry Project:i18n release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TinaHeiligers @elasticmachine @kibanamachine @joshdover @pgayvallet @lukeelmers