Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct version of Podium #84270

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Use correct version of Podium #84270

merged 1 commit into from
Nov 24, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Nov 24, 2020

This snug in when all package.json files was consolidated in #80015

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 24, 2020
@watson watson self-assigned this Nov 24, 2020
@watson watson requested a review from a team November 24, 2020 19:00
spalger
spalger approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 752.7KB 752.7KB -18.0B

Distributable file count

id before after diff
default 43049 43011 -38
oss 22581 22543 -38

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.5KB 60.5KB -18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit 1159169 into elastic:master Nov 24, 2020
@watson watson deleted the fix-podium-use branch November 24, 2020 21:15
@watson watson mentioned this pull request Nov 24, 2020
Merged
watson added a commit that referenced this pull request Nov 25, 2020
@watson
Use correct version of Podium (#84270) (#84280)
9d8d283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@watson watson

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watson @kibanamachine @spalger