Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Stop collecting Kibana Usage in bulkUploader #83546

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 17, 2020

Summary

Bulk Uploader (used for the deprecated self-monitoring feature) currently uses usageCollection to collect Kibana OpsMetrics and Settings stats every 10s, and every 24h it also collects Kibana Usage.

The Kibana Usage won't be needed once we complete #82638, and the 10s-collected stats can be owned by the plugin itself so future changes do not break Monitoring's behaviour.

This PR stops collecting Kibana Usage and implements the OpsMetrics and Settings collectors in the monitoring plugin itself. This way it no longer depends on usageCollection's APIs.

Related to #83521.

⚠️ It cannot be merged until #82638 is completed or Telemetry data will be incomplete.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 17, 2020
@afharo afharo force-pushed the monitoring/remove-usageCollection-usage-in-bulk_uploader branch from 778834d to bf5a108 Compare November 17, 2020 16:31
@afharo afharo force-pushed the monitoring/remove-usageCollection-usage-in-bulk_uploader branch from bf5a108 to f8a2213 Compare November 18, 2020 09:47
@afharo afharo marked this pull request as ready for review November 18, 2020 13:02
@afharo afharo requested a review from a team November 18, 2020 13:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, very nice work here! Thanks for taking this effort on! LGTM!

@afharo afharo merged commit ff19bf5 into elastic:master Nov 20, 2020
@afharo afharo deleted the monitoring/remove-usageCollection-usage-in-bulk_uploader branch November 20, 2020 08:55
afharo added a commit that referenced this pull request Nov 20, 2020
…83898)

# Conflicts:
#	x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_settings_collector.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 20, 2020
* master: (38 commits)
  [ML] Data frame analytics: Adds functionality to map view (elastic#83710)
  Add usage collection for savedObject tagging (elastic#83160)
  [SECURITY_SOLUTION] 145: Advanced Policy Tests (elastic#82898)
  [APM] Service overview transactions table (elastic#83429)
  [ML] Fix Single Metric Viewer not loading if job is metric with no partition (elastic#83880)
  do not export types from 3rd party modules as 'type' (elastic#83803)
  [Fleet] Allow to send SETTINGS action (elastic#83707)
  Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Alert Details Alert Instances renders the active alert instances (elastic#83478)
  [Uptime]Reduce chart height on monitor detail page (elastic#83777)
  [APM] Prefer `APIReturnType` over `PromiseReturnType` (elastic#83843)
  [Observability] Fix telemetry for Observability Overview (elastic#83847)
  [Alerting] Adds generic UI for the definition of conditions for Action Groups (elastic#83278)
  ensure workload agg doesnt run until next interval when it fails (elastic#83632)
  [ILM] Policy form should not throw away data (elastic#83077)
  [Monitoring] Stop collecting Kibana Usage in bulkUploader (elastic#83546)
  [TSVB] fix wrong imports (elastic#83798)
  [APM] Correlations UI POC (elastic#82256)
  list all the refs in  tsconfig.json (elastic#83678)
  Bump jest (and related packages) to v26.6.3 (elastic#83724)
  Functional tests - stabilize reporting tests for cloud execution (elastic#83787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants