Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
8330/bug/term-agg-size-0
branch
from
743efcf
to
fa12b92
Compare
…rn an error if you provide a size of 0. - Display feedback if a Dashboard or Visualization is loaded that already violates this constraint. - Add ElasticsearchError class and isTermSizeZeroError helper.
cjcenizal
force-pushed
the
8330/bug/term-agg-size-0
branch
from
fa12b92
to
4fefae1
Compare
|
LGTM |
1 similar comment
|
LGTM |
jbudz
reviewed
Sep 20, 2016
| @@ -155,7 +159,17 @@ uiModules | |||
| return searchSource.onResults().then(onResults); | |||
| }).catch(notify.fatal); | |||
|
|
|||
| searchSource.onError(notify.error).catch(notify.fatal); | |||
| searchSource.onError(e => { | |||
| if (isTermSizeZeroError(e)) { | |||
There was a problem hiding this comment.
would it be possible to include vis titles for unknown errors too?
There was a problem hiding this comment.
I like this idea, but it gets a little tricky given the implicit way our notification error messages are created. Let's address this as part of #8194
elastic-jasper
added a commit
that referenced
this pull request
Sep 20, 2016
--------- **Commit 1:** Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. - Display feedback if a Dashboard or Visualization is loaded that already violates this constraint. - Add ElasticsearchError class and isTermSizeZeroError helper. * Original sha: 4fefae1 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 20, 2016
--------- **Commit 1:** Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. - Display feedback if a Dashboard or Visualization is loaded that already violates this constraint. - Add ElasticsearchError class and isTermSizeZeroError helper. * Original sha: 4fefae1 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z
cjcenizal
added a commit
that referenced
this pull request
Sep 20, 2016
[backport] PR #8339 to 5.x - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.
cjcenizal
added a commit
that referenced
this pull request
Sep 20, 2016
[backport] PR #8339 to 5.0 - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. - Display feedback if a Dashboard or Visualization is loaded that already violates this constraint. - Add ElasticsearchError class and isTermSizeZeroError helper. * Original sha: cd604dea0c6ffcb454c96e3ded5c00690d9af33c [formerly 4fefae1] * Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z Former-commit-id: 0ca20ac
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8339 to 5.x - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. Former-commit-id: a4df947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8330
Changes