Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Use Storybook Controls instead of Knobs (#80705) #81398

Merged
merged 5 commits into from
Oct 27, 2020
Merged

[7.x] Use Storybook Controls instead of Knobs (#80705) #81398

merged 5 commits into from
Oct 27, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 21, 2020

Backports the following commits to 7.x:

@smith
Use Storybook Controls instead of Knobs (elastic#80705)
4d51236 
* Change an example in embeddable to use controls instead of knobs
* Add controls to SyncBadge APM story
* Convert both to [CSF](https://storybook.js.org/docs/react/api/csf)
* Remove the Knobs addon from the default Storybook configuration

Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
@smith smith added the backport label Oct 21, 2020
@smith
Copy link
Contributor Author

smith commented Oct 21, 2020

jenkins run the e2e

@smith
Copy link
Contributor Author

smith commented Oct 26, 2020

@elasticmachine merge upstream

1 similar comment
@smith
Copy link
Contributor Author

smith commented Oct 26, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Oct 27, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Oct 27, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Oct 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 53b4a3d into elastic:7.x Oct 27, 2020
@smith smith deleted the backport/7.x/pr-80705 branch October 27, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smith @kibanamachine