Allow idleTimeout/lifespan larger than 32-bit signed integer. #79858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
release_note:fix
Team:Security
azasypkin
commented
Oct 7, 2020
| */ | ||
| private startTimer(updater: (timeoutID: number) => void, callback: () => void, timeout: number) { | ||
| // Max timeout is the largest possible 32-bit signed integer or 2,147,483,647 or 0x7fffffff. | ||
| const maxTimeout = 0x7fffffff; |
There was a problem hiding this comment.
note: didn't want to create a dedicated top level const for this purely "technical" thing....
|
Pinging @elastic/kibana-security (Team:Security) |
jportner
approved these changes
Oct 7, 2020
| test(`stop works properly for large timeouts`, async () => { | ||
| http.fetch.mockResolvedValue({ | ||
| ...defaultSessionInfo, | ||
| idleTimeoutExpiration: now + 5_000_000_000, |
There was a problem hiding this comment.
TIL you can use underscores in JS numbers 😁 pretty cool
There was a problem hiding this comment.
Yeah, I like it as well. Unfortunately we cannot use it in a non-test code yet (at least something was complaining about that during the build) 🙁 Should probably be easy to tweak our build/transpilation pipeline though, I see it's Stage 4 proposal already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add a client-side
startTimerfunction that allows us to workaround a maximum allowed JavaScript timeout (32-bit signed integer or 2,147,483,647 ms or 24.8 days). The main idea here is that in case of large timeout values this method recursively callssetTimeoutkeeping track of current timeout ID so that it can be cleared at any time.Unblocks: #68885
Fixes: #22374
Release note: Kibana can now properly handle values for
xpack.security.session.idleTimeoutandxpack.security.session.lifespanthat are larger than ~24 days.