Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn/config] don't include x-pack/examples with --oss #79032

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[kbn/config] don't include x-pack/examples with --oss #79032

merged 1 commit into from
Sep 30, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 30, 2020 •
edited by tylersmalley
Loading

When --oss and --run-examples are used together we shouldn't include the x-pack/examples plugins. These plugins require x-pack plugins which aren't included for obvious reasons.

Related to #78656

@spalger spalger added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 71dc864 into elastic:master Sep 30, 2020
@spalger spalger deleted the fix/kbn-config/limit-x-pack-examples branch September 30, 2020 22:19
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79032 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 2, 2020
spalger added a commit to spalger/kibana that referenced this pull request Oct 2, 2020
@spalger
[kbn/config] don't include x-pack/examples with --oss (elastic#79032)
973126a 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger spalger mentioned this pull request Oct 2, 2020
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 3, 2020
spalger added a commit that referenced this pull request Oct 3, 2020
@spalger @kibanamachine
[kbn/config] don't include x-pack/examples with --oss (#79032) (#79381)
9eeff6d 
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @kibanamachine @tylersmalley