Fix APM header wrapping #78845
Merged
Fix APM header wrapping #78845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `wrap` to the flex group for the APM header and remove the `break-all` CSS. Makes it so the date picker doesn't get cut off on narrow screens and the header text does not wrap unnecessarily.
|
Pinging @elastic/apm-ui (Team:apm) |
|
👏 Thank you! |
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 29, 2020
Add `wrap` to the flex group for the APM header and remove the `break-all` CSS. Makes it so the date picker doesn't get cut off on narrow screens and the header text does not wrap unnecessarily.
smith
added a commit
that referenced
this pull request
Sep 30, 2020
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
Sep 30, 2020
Add `wrap` to the flex group for the APM header and remove the `break-all` CSS. Makes it so the date picker doesn't get cut off on narrow screens and the header text does not wrap unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
wrapto the flex group for the APM header and remove thebreak-allCSS.Makes it so the date picker doesn't get cut off on narrow screens and the header text does not wrap unnecessarily.
Home
Before
After
Transaction (with breakable characters)
Before
After
Transaction (without breakable characters)
Before
After
note that in this last case the transaction name may be cut off but is still visible elsewhere on the page and we don't lose the use of the date picker.