Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Store Expanded Panel Id in URL #78684

Merged
merged 5 commits into from
Sep 29, 2020
Merged

[Dashboard] Store Expanded Panel Id in URL #78684

merged 5 commits into from
Sep 29, 2020

Conversation

ThomThomson
Copy link
Contributor

Summary

Adds the expandedPanelId prop to the app state in the url. This Closes #74703, and paves the way for "Share-To using Fullscreen as landing page".

Full Screen

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.10.0 labels Sep 28, 2020
@ThomThomson ThomThomson marked this pull request as ready for review September 29, 2020 13:20
@ThomThomson ThomThomson requested a review from a team September 29, 2020 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id value diff baseline
dashboard 570.4KB +204.0B 570.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 33f8ebd into elastic:master Sep 29, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 29, 2020
@ThomThomson
[Dashboard] Store Expanded Panel Id in URL (elastic#78684)
9044b06 
* Added expandedPanelId to dashboard app state
@ThomThomson ThomThomson mentioned this pull request Sep 29, 2020
Merged
ThomThomson added a commit that referenced this pull request Sep 29, 2020
@ThomThomson
[Dashboard] Store Expanded Panel Id in URL (#78684) (#78831)
46a6959 
* Added expandedPanelId to dashboard app state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser back button doesn't work as expected on full screen mode on dashboard panels.
4 participants
@ThomThomson @elasticmachine @kibanamachine @dej611