Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry icons and data telemetry #78499

Merged
merged 9 commits into from
Sep 29, 2020
Merged

OpenTelemetry icons and data telemetry #78499

merged 9 commits into from
Sep 29, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Sep 24, 2020

Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services.

Services that report "otlp" as their agent name use the OpenTelemetry icon.

The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.

In these screenshots (made by running https://github.com/elastic/apm-contrib/tree/master/opentelemetry), frontend is an OpenTelemetry-instrumented Node.js app (agent.name = "opentelemetry/nodejs") and backend is an OpenTelemetry-instrumented Python app where its collector does not report the agent name (agent.name = "otlp"):

image

image

Fixes #75978.

Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services.

Services that report "otlp" as their agent name use the OpenTelemetry icon.

The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.
@smith smith requested a review from a team September 24, 2020 21:54
@smith smith requested a review from a team as a code owner September 24, 2020 21:54
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@@ -524,6 +524,710 @@ exports[`APM telemetry helpers getApmTelemetry generates a JSON object with the
}
}
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/telemetry this diff shows the new fields needed to be added to the mapping.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love we get to eventually integrate this collector to the schema convention (#72736). This week I'll be working on some schema improvements. Hopefully, I'll get there so we don't need to maintain this snapshot.

@mindbat FYI about APM added fields

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, @afharo!

@smith Once these changes are ready, would you mind opening a mapping update issue, in the Infra repo (with a list of the new fields), so we can track the changes needed for these to show up in the indexed data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened elastic/telemetry#461.

Copy link

@mindbat mindbat Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smith Ah, that request needs to go to the Infra repo, not telemetry (see my link above).

We've (Infra) taken over the maintenance of the telemetry cluster, so we'll be making these changes 😉

x-pack/plugins/apm/common/agent_name.test.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/common/agent_name.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/common/agent_name.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/common/agent_name.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/common/agent_name.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/common/agent_name.test.ts Outdated Show resolved Hide resolved
@dgieselaar
Copy link
Member

@smith we should also change ratio from a long to a float. Do you mind changing that here as well?

@smith smith requested a review from a team as a code owner September 29, 2020 16:49
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
apm 1257 +1 1256

async chunks size

id value diff baseline
apm 4.1MB +4.2KB 4.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit c2ef407 into elastic:master Sep 29, 2020
@smith smith deleted the nls/otel branch September 29, 2020 19:33
smith added a commit to smith/kibana that referenced this pull request Sep 29, 2020
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services.

Services that report "otlp" as their agent name use the OpenTelemetry icon.

The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.

Change "ratio" in the telemetry to a float.
smith added a commit that referenced this pull request Sep 30, 2020
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services.

Services that report "otlp" as their agent name use the OpenTelemetry icon.

The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.

Change "ratio" in the telemetry to a float.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Track OpenTelemetry usage
8 participants