-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry icons and data telemetry #78499
Conversation
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services. Services that report "otlp" as their agent name use the OpenTelemetry icon. The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.
Pinging @elastic/apm-ui (Team:apm) |
@@ -524,6 +524,710 @@ exports[`APM telemetry helpers getApmTelemetry generates a JSON object with the | |||
} | |||
} | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/telemetry this diff shows the new fields needed to be added to the mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping, @afharo!
@smith Once these changes are ready, would you mind opening a mapping update issue, in the Infra repo (with a list of the new fields), so we can track the changes needed for these to show up in the indexed data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened elastic/telemetry#461.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smith Ah, that request needs to go to the Infra repo, not telemetry (see my link above).
We've (Infra) taken over the maintenance of the telemetry cluster, so we'll be making these changes 😉
@smith we should also change |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services. Services that report "otlp" as their agent name use the OpenTelemetry icon. The OpenTelemetry agents are now collected in the data telemetry along with the other agent names. Change "ratio" in the telemetry to a float.
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services. Services that report "otlp" as their agent name use the OpenTelemetry icon. The OpenTelemetry agents are now collected in the data telemetry along with the other agent names. Change "ratio" in the telemetry to a float.
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services.
Services that report "otlp" as their agent name use the OpenTelemetry icon.
The OpenTelemetry agents are now collected in the data telemetry along with the other agent names.
In these screenshots (made by running https://github.com/elastic/apm-contrib/tree/master/opentelemetry), frontend is an OpenTelemetry-instrumented Node.js app (
agent.name
= "opentelemetry/nodejs") and backend is an OpenTelemetry-instrumented Python app where its collector does not report the agent name (agent.name
= "otlp"):Fixes #75978.