Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Resolver] 2 new functions to DAL #78477

Merged
merged 6 commits into from
Sep 25, 2020
Merged

[Security Solution][Resolver] 2 new functions to DAL #78477

merged 6 commits into from
Sep 25, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Sep 24, 2020

Summary

co-author: @jonathan-buttner

  1. Changes the DAL to implement the new contract with the two new functions (eventsWithEntityIDAndCategory, and event).
  2. Adjusts the Types file to reflect the new shape of the DAL
  3. Reroute the relatedEvents from the DAL to the new underlying API
  4. Adjust mocks ( h/t @oatkiller ) to use the new contract from the DAL

For maintainers

@bkimmel bkimmel marked this pull request as ready for review September 24, 2020 19:18
@bkimmel bkimmel requested review from a team as code owners September 24, 2020 19:18
@bkimmel bkimmel added v8.0.0 v7.10.0 Feature:Resolver Security Solution Resolver feature labels Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@bkimmel bkimmel added the release_note:skip Skip the PR/issue when compiling release notes label Sep 24, 2020
@bkimmel bkimmel changed the title Added 2 new functions to DAL, adjusted old one to use new API [Security Solution][Resolver] 2 new functions to DAL Sep 24, 2020
@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 24, 2020

@elasticmachine merge upstream

@bkimmel
Copy link
Contributor Author

bkimmel commented Sep 25, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
securitySolution 10.2MB +9.9KB 10.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel merged commit 341c1ac into elastic:master Sep 25, 2020
@bkimmel bkimmel deleted the resolver/add-events-to-dal branch September 25, 2020 13:29
bkimmel added a commit that referenced this pull request Sep 25, 2020
* Added 2 new functions to DAL, adjusted old one to use new API

* update mocks to work with interface

* change to optional params

Co-authored-by: oatkiller <robert.austin@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 28, 2020
* master: (226 commits)
  [Enterprise Search] Added Logic for the Credentials View (elastic#77626)
  [CSM] Js errors (elastic#77919)
  Add the @kbn/apm-config-loader package (elastic#77855)
  [Security Solution] Refactor useSelector (elastic#75297)
  Implement tagcloud renderer (elastic#77910)
  [APM] Alerting: Add global option to create all alert types (elastic#78151)
  [Ingest pipelines] Upload indexed document to test a pipeline (elastic#77939)
  TypeScript cleanup in visualizations plugin (elastic#78428)
  Lazy load metric & mardown visualizations (elastic#78391)
  [Detections][EQL] EQL rule execution in detection engine (elastic#77419)
  Update tutorial-full-experience.asciidoc (elastic#75836)
  Update tutorial-define-index.asciidoc (elastic#75754)
  Add support for runtime field types to mappings editor. (elastic#77420)
  [Monitoring] Usage collection (elastic#75878)
  [Docs][Actions] Add docs for Jira and IBM Resilient (elastic#78316)
  [Security Solution][Resolver] Update @timestamp formatting (elastic#78166)
  [Security Solution] Fix app layout (elastic#76668)
  [Security Solution][Resolver] 2 new functions to DAL (elastic#78477)
  Adds new elasticsearch client to telemetry plugin (elastic#78046)
  skip flaky suite (elastic#78512) (elastic#78511) (elastic#78510) (elastic#78509) (elastic#78508) (elastic#78507) (elastic#78506) (elastic#78505) (elastic#78504) (elastic#78503) (elastic#78502) (elastic#78501) (elastic#78500)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants