Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Rollback the logger & try/catch changes from #77640 (#77806) #78197

Merged
merged 2 commits into from
Sep 23, 2020
Merged

[7.x] Rollback the logger & try/catch changes from #77640 (#77806) #78197

merged 2 commits into from
Sep 23, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Sep 22, 2020

Rollback the logger & try/catch changes from elastic#77640 (elastic#7…
22f2357 
…7806)

* Doing a try/catch and re-throwing doesn't gain us anything. We already catching the error in the route handler
 * We have logging for the issue in the existing handler. We also don't pass a logging context to functions
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit 32d131a into elastic:7.x Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfsiii @kibanamachine