Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Map layout changes (#77132) #77526

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Commits on Sep 15, 2020

  1. Map layout changes (elastic#77132)

    These changes make the map work better with auto-refresh and with dragged nodes.
    
    Extract all event handling out of the Cytoscape component into a hook.
    Use React.memo to only render when the list of element ids has changed.
    Only do a fit on the layout if we're going from 0 to more than 0 elements.
    Instead of removing all the nodes on rerender, only remove the ones that aren't in the new list.
    Trigger a custom:data event instead of data when we receive fetched data. Before we triggered a data event which would trigger a layout if you called data() on an element.
    Don't trigger a deselect when we get new data, so popovers stay open when we get new data.
    Animate the layout on changes.
    When we do a layout, exclude selected nodes and nodes that have been dragged.
    When we set the time range to something low (like the default of 15m) and a fast refresh interval (1-3s) the edges we get back from the API are not consistent, so you can see the map changing frequently.
    
    See this video for an example: https://www.dropbox.com/s/jsq2bffxdw61xhu/77132.mov?dl=0
    
    Fixes elastic#73156.
    Fixes elastic#76936.
    smith committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f024a22 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Configuration menu
    Copy the full SHA
    270ea8c View commit details
    Browse the repository at this point in the history