Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSM] Url search #77516

Merged
merged 34 commits into from
Sep 23, 2020
Merged

[CSM] Url search #77516

merged 34 commits into from
Sep 23, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 15, 2020 •
edited
Loading

Summary

Fixes: #77753

Users can choose a single/multiple URLs
Users can put in a wildcard URL and all matching URLs will be aggregated into the displayed values

image

@shahzad31 shahzad31 changed the title Url search [CSM] Url search Sep 17, 2020
@shahzad31 shahzad31 self-assigned this Sep 17, 2020
@shahzad31 shahzad31 marked this pull request as ready for review September 17, 2020 14:27
@shahzad31 shahzad31 requested review from a team as code owners September 17, 2020 14:27
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

justinkambic
justinkambic reviewed Sep 18, 2020
View reviewed changes
x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature Outdated Show resolved Hide resolved
x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/url_search_filter.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature Outdated Show resolved Hide resolved
x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/url_search_filter.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/VisitorBreakdown/index.tsx Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/URLFilter/URLSearch/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/URLFilter/URLSearch/index.tsx Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/RumDashboard/URLFilter/URLSearch/index.tsx Outdated Show resolved Hide resolved
shahzad31 and others added 8 commits September 18, 2020 18:45
@shahzad31 @justinkambic
Update x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature
ba134db 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@shahzad31 @justinkambic
Update x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/ur…
a71619c 
…l_search_filter.ts

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@shahzad31 @justinkambic
Update x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature
6d06c0e 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@shahzad31 @justinkambic
Update x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm/ur…
4f80373 
…l_search_filter.ts

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@shahzad31
Merge branch 'master' into url-search
1c2859b
@shahzad31
update label
ecfc910
@shahzad31
Merge branch 'url-search' of https://github.com/shahzad31/kibana into…
fbd9ec8 
… url-search
@shahzad31
reduce concurrency
5d00c79
@shahzad31 shahzad31 mentioned this pull request Sep 18, 2020
Closed
justinkambic
justinkambic approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
apm 1252 +5 1247

async chunks size

id value diff baseline
apm 4.2MB +21.7KB 4.2MB

distributable file count

id value diff baseline
default 45944 +2 45942

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahzad31 shahzad31 merged commit 9276a16 into elastic:master Sep 23, 2020
@shahzad31 shahzad31 deleted the url-search branch September 23, 2020 10:51
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 23, 2020
@gmmorris
Merge branch 'master' into actions/pagerduty-dedup
097b99d 
* master: (31 commits)
  skip tests for old pacakge (elastic#78194)
  [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872)
  [Lens] Rename "telemetry" to "stats" (elastic#78125)
  [CSM] Url search (elastic#77516)
  [Drilldowns] Config to disable URL Drilldown  (elastic#77887)
  [Lens] Combined histogram/range aggregation for numbers (elastic#76121)
  Remove legacy plugins support (elastic#77599)
  'Auto' interval must be correctly calculated for natural numbers (elastic#77995)
  [CSM] fix ingest data retry order messed up (elastic#78163)
  Add response status helpers (elastic#78006)
  Bump react-beautiful-dnd (elastic#78028)
  [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004)
  Index pattern  - refactor constructor (elastic#77791)
  Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192)
  Remove [key: string]: any; from IIndexPattern (elastic#77968)
  Remove requirement for manage_index_templates privilege for Index Management (elastic#77377)
  [Ingest Manager] Agent bulk actions UI (elastic#77690)
  [Metrics UI] Add inventory view timeline (elastic#77804)
  Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101)
  Update to latest rum-react (elastic#78193)
  ...
@shahzad31 shahzad31 mentioned this pull request Sep 24, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 24, 2020
@shahzad31 @justinkambic @elasticmachine
[CSM] Url search (elastic#77516)
71f2736 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
shahzad31 added a commit that referenced this pull request Sep 24, 2020
@shahzad31 @justinkambic @elasticmachine
[7.x] [CSM] Url search (#77516) (#78406)
fb087e9 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sorenlouv sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@justinkambic justinkambic justinkambic approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees

@shahzad31 shahzad31

Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CSM] Url Search
5 participants
@shahzad31 @elasticmachine @kibanamachine @sorenlouv @justinkambic