Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Correctly filter for log rate anomaly examples with missing dataset #76775

Merged
merged 2 commits into from
Sep 22, 2020
Merged

[Logs UI] Correctly filter for log rate anomaly examples with missing dataset #76775

merged 2 commits into from
Sep 22, 2020

Conversation

weltenwort
Copy link
Member

Summary

This fixes #76493 by querying for the "unknown" (i.e. empty) dataset using an exists clause. This should be in line with how ML anomaly detection treats missing partition values.

Testing hints

  • The "unknown" dataset is what documents without an event.dataset value get assigned to during ML analysis, so the testing data need to contain some of these.
  • This should apply to both

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 labels Sep 4, 2020
@weltenwort weltenwort added this to the Logs UI 7.10 milestone Sep 4, 2020
@weltenwort weltenwort requested a review from a team as a code owner September 4, 2020 14:12
@weltenwort weltenwort self-assigned this Sep 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez self-requested a review September 9, 2020 11:18
afgomez
afgomez approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. I correctly shows only examples without event.dataset.

LGTM! 🎉

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort merged commit e0aeebc into elastic:master Sep 22, 2020
@weltenwort weltenwort deleted the logs-ui-fix-example-unknown-dataset-query branch September 22, 2020 17:32
@weltenwort weltenwort mentioned this pull request Sep 22, 2020
Merged
weltenwort added a commit to weltenwort/kibana that referenced this pull request Sep 22, 2020
@weltenwort
[Logs UI] Correctly filter for log rate anomaly examples with missing…
aacecb1 
… dataset (elastic#76775)

This fixes elastic#76493 by querying for the "unknown" (i.e. empty) dataset using an exists clause. This should be in line with how ML anomaly detection treats missing partition values.
weltenwort added a commit that referenced this pull request Sep 22, 2020
@weltenwort
[7.x] [Logs UI] Correctly filter for log rate anomaly examples with m…
1542029 
…issing dataset (#76775) (#78184)

Backports the following commits to 7.x:
 - [Logs UI] Correctly filter for log rate anomaly examples with missing dataset (#76775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.10
Development

Successfully merging this pull request may close these issues.

[Logs UI] Anomaly example query for unknown dataset is too broad
4 participants
@weltenwort @elasticmachine @kibanamachine @afgomez