xpack_main legacy plugin pre-removal cleanup #76257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:Legacy Removal
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
approved these changes
Aug 31, 2020
| @@ -22,9 +22,6 @@ export function setupXPackMain(server) { | |||
|
|
|||
| server.ext('onPreResponse', (request, h) => injectXPackInfoSignature(info, request, h)); | |||
There was a problem hiding this comment.
I suppose we can remove it as no plugins read it anymore. And remove tests https://github.com/elastic/kibana/tree/bf04235dae35452061cc7ea3d86d96c19a58206c/x-pack/test/licensing_plugin/legacy
There was a problem hiding this comment.
Ok, wasn't sure. Will do
💚 Build SucceededBuild metricsoss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Sep 1, 2020
* cleanup xpack_main legacy plugin, remove capabilities mixin * fix test env * delete injectXpackSignature and related tests # Conflicts: # x-pack/legacy/plugins/xpack_main/index.js # x-pack/scripts/functional_tests.js
pgayvallet
added a commit
that referenced
this pull request
Sep 1, 2020
* xpack_main legacy plugin pre-removal cleanup (#76257) * cleanup xpack_main legacy plugin, remove capabilities mixin * fix test env * delete injectXpackSignature and related tests # Conflicts: # x-pack/legacy/plugins/xpack_main/index.js # x-pack/scripts/functional_tests.js * remove unused keys * create the xpackLegacy plugin * update plugin list * fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #71927
capabilitiesMixinfrom the legacy server as this was the last legacy plugin to registeruiCapabilities