Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor Network Top Countries to use Search Strategy #76244

Merged
merged 10 commits into from
Sep 3, 2020
Merged

[Security Solution] Refactor Network Top Countries to use Search Strategy #76244

merged 10 commits into from
Sep 3, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 29, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/network-…
804d87c 
…top-countries-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/network/index.ts
#	x-pack/plugins/security_solution/public/network/containers/network_http/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/tls/index.tsx
#	x-pack/plugins/security_solution/public/network/pages/navigation/tls_query_tab_body.tsx
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/query.http_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/tls/query.tls_network.dsl.ts
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/network-…
eee296f 
…top-countries-search-strategy
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 2, 2020 14:45
@patrykkopycinski patrykkopycinski self-assigned this Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

angorayc
angorayc approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1941 +2 1939

async chunks size

id value diff baseline
securitySolution 9.8MB +12.4KB 9.8MB

distributable file count

id value diff baseline
total 45466 +6 45460

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit e2f283b into elastic:master Sep 3, 2020
@patrykkopycinski patrykkopycinski deleted the feat/network-top-countries-search-strategy branch September 3, 2020 16:06
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 3, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 3, 2020
@patrykkopycinski
[Security Solution] Refactor Network Top Countries to use Search Stra…
8003bc0 
…tegy (elastic#76244)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 3, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
c564990 
* master: (340 commits)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  [i18n] Integrate 7.9.1 Translations (elastic#76391)
  [APM] Update aggregations to support script sources (elastic#76429)
  [Security Solution] Refactor Network Top Countries to use Search Strategy (elastic#76244)
  Document security settings available on ESS (elastic#76513)
  [Ingest Manager] Add input revision to the config send to the agent (elastic#76327)
  [DOCS] Identifies cloud settings for Monitoring (elastic#76579)
  [DOCS] Identifies Cloud settings in Dev Tools (elastic#76583)
  [Ingest Manager] Better default value for fleet long polling timeout (elastic#76393)
  [data.indexPatterns] Fix broken rollup index pattern creation (elastic#76593)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  ...
patrykkopycinski added a commit that referenced this pull request Sep 3, 2020
@patrykkopycinski
[Security Solution] Refactor Network Top Countries to use Search Stra…
b71b2c1 
…tegy (#76244) (#76666)
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS