Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI text strings in Integrations and Fleet tabs #75837

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

dedemorton
Copy link
Contributor

Summary

Edits UI text strings for Integrations and Fleet tags in Ingest Manager.

Checklist

Delete any items that are not applicable to this PR.

@dedemorton dedemorton added v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 25, 2020
@dedemorton
Copy link
Contributor Author

dedemorton commented Sep 19, 2020

@gchaps and I wanted to suggest additional edits, but given the plans for additional design improvements (YAY!), I'd like to get these changes merged, then revisit the edit when the design is further along.

@dedemorton dedemorton marked this pull request as ready for review September 19, 2020 00:41
@dedemorton dedemorton requested a review from a team September 19, 2020 00:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@dedemorton
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Sep 21, 2020
@dedemorton
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +104.0B 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dedemorton dedemorton merged commit 4dc0c12 into elastic:master Sep 22, 2020
@dedemorton dedemorton deleted the edit_ui_text_round2 branch September 22, 2020 02:32
dedemorton added a commit to dedemorton/kibana that referenced this pull request Sep 22, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dedemorton added a commit that referenced this pull request Sep 22, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
* master: (45 commits)
  [CSM] Use stacked chart for page views (elastic#78042)
  [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091)
  Remove service map beta badge (elastic#78039)
  [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124)
  [Alerting] optimize calculation of unmuted alert instances (elastic#78021)
  call .destroy on ace when react component unmounts (elastic#78132)
  [Ingest Manager] Fix agent action acknowledgement (elastic#78089)
  [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127)
  [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606)
  Bump backport to 5.6.0 (elastic#78097)
  [Actions] adds a Test Connector tab in the Connectors list (elastic#77365)
  [Uptime] Improve ping chart axis (elastic#77992)
  [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363)
  [UiActions] Remove duplicate apply filter action  (elastic#77485)
  [APM] Use transaction metrics for transaction error rate (elastic#78009)
  [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983)
  Edit UI text strings in Integrations and Fleet tabs (elastic#75837)
  [baseline capture] switch to large workers (elastic#78109)
  [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956)
  [Mappings editor] Add support for point field type (elastic#77543)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants