Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB Inaccurate Group By #73683

Merged
merged 1 commit into from
Jul 30, 2020
Merged

TSVB Inaccurate Group By #73683

merged 1 commit into from
Jul 30, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 29, 2020 •
edited
Loading

Closes: #62081

Describe the bug:
Potentially confusing TSVB functionality. Group by settings configured in any TSVB vis apply to all visualization types, even when the series and related aggregation are not shown.

Steps to reproduce:

  1. Add a test data set
  2. Create a new TSVB visualization
  3. In the time series, add two series
  4. In the second series, apply a group by (like terms)
  5. Switch to the Gauge visualization, and see that the group by still applies even though it is not visible.

Expected behavior:
The series configuration should show all configuration items that apply to the current visualization

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Jul 29, 2020
@alexwizp alexwizp added v7.10.0 v8.0.0 release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:TSVB TSVB (Time Series Visual Builder) labels Jul 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
visTypeTimeseries 1.8MB +321.0B 1.8MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome, and the issue seems to be resolved. Code LGTM!

@alexwizp alexwizp marked this pull request as ready for review July 29, 2020 16:57
@alexwizp alexwizp requested a review from a team July 29, 2020 16:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Safari, LGTM 🍰

@alexwizp alexwizp merged commit 3cb34a0 into elastic:master Jul 30, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 30, 2020
@alexwizp
TSVB Inaccurate Group By (elastic#73683)
1cb3bba 
Closes: elastic#62081
@alexwizp alexwizp mentioned this pull request Jul 30, 2020
Merged
alexwizp added a commit that referenced this pull request Jul 30, 2020
@alexwizp
TSVB Inaccurate Group By (#73683) (#73776)
e5823ec 
Closes: #62081
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'master' into alerting/refresh-on-deletion
d63f1f7 
* master:
  [Vega][Inspector] Request panel should show correct names for requests (elastic#73655)
  [Security Solution] Update filter (elastic#73350)
  TSVB Inaccurate Group By (elastic#73683)
  [Vega][Inspect panel] Write tutorials and reference (elastic#73262)
  [ML] Removing node info check for file data viz import (elastic#73717)
  check that pathname has been updated. ignore other parts (elastic#73689)
  [build] rewrite source as transpiled JS later in the process (elastic#73749)
  Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734)
  skip flaky suite (elastic#69783) (elastic#70043)
  [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588)
  skip failing suite (elastic#58815)
  [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732)
  [DOCS] Changes level offset of monitoring pages (elastic#73573)
  Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662)
  [ML] Transforms/DFA: Change action button size back to 'xs'.
  [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545)
  [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSVB Inaccurate Group By
5 participants
@alexwizp @kibanamachine @elasticmachine @ThomThomson @stratoula