[Maps] fix application state filters transfer from other kibana application to maps application #73516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation to maps application
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
Jul 28, 2020
| @@ -102,14 +102,6 @@ export class MapsAppView extends React.Component { | |||
| this._globalSyncChangeMonitorSubscription.unsubscribe(); | |||
| } | |||
|
|
|||
| // Clean up app state filters | |||
There was a problem hiding this comment.
No longer need to clean-up on unmount since app state filters gets cleaned up on mount
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
kindsun
approved these changes
Jul 30, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 30, 2020
…cation to maps application (elastic#73516) * [Maps] fix application state filters transfer from other kibana application to maps application * clean up comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 30, 2020
…cation to maps application (elastic#73516) * [Maps] fix application state filters transfer from other kibana application to maps application * clean up comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jul 30, 2020
…cation to maps application (#73516) (#73829) * [Maps] fix application state filters transfer from other kibana application to maps application * clean up comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jul 30, 2020
…cation to maps application (#73516) (#73830) * [Maps] fix application state filters transfer from other kibana application to maps application * clean up comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73354
The regression was caused as a side effect of moving to new platform. Prior to new platform, switching to maps would trigger a refresh and clean filterManager instance. Without the page reload, filterManager contains application state filters from other Kibana applications. This PR just clears application state filters from filter manager when setting up application state syncing.