Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] [Detections] Reject on value list + other exception entries in single exception item (#73158) #73503

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

dhurley14
Copy link
Contributor

Backports the following commits to 7.x:

… single exception item (elastic#73158)

Add validation to reject when value list and other exception type are entries in the same exception item. Also adds tests for this situation on the schema validation
@dhurley14
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: expected 'message' to not equal 'message'
    at Context.eval (http://localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts:686:40)

Build metrics

page load bundle size

id value diff baseline
lists 269.7KB +286.0B 269.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit caa76a5 into elastic:7.x Jul 29, 2020
@dhurley14 dhurley14 deleted the backport/7.x/pr-73158 branch July 29, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants